Bug 187907 - Install of converters/p5-Text-Iconv Fails
Summary: Install of converters/p5-Text-Iconv Fails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 18:40 UTC by Tom
Modified: 2014-03-25 18:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom 2014-03-24 18:40:00 UTC
Receive the following errors attempting to install converters/p5-Text-Iconv:

===>  Building for p5-Text-Iconv-1.7
cc -c  -I/usr/local/include  -O2 -pipe -DLIBICONV_PLUG -fno-strict-aliasing -O2 -pipe -fno-strict-aliasing    -DVERSION=\"1.7\"  -DXS_VERSION=\"1.7\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.16/mach/CORE"   Iconv.c
Iconv.xs:219:11: warning: implicit declaration of function 'iconvctl' is invalid in C99 [-Wimplicit-function-declaration]
   return iconvctl(obj->handle, request, arg);
          ^
Iconv.xs:321:11: error: use of undeclared identifier 'ICONV_TRIVIALP'
         reqno = ICONV_TRIVIALP;
                 ^
Iconv.xs:323:11: error: use of undeclared identifier 'ICONV_GET_TRANSLITERATE'
         reqno = ICONV_GET_TRANSLITERATE;
                 ^
Iconv.xs:325:11: error: use of undeclared identifier 'ICONV_GET_DISCARD_ILSEQ'
         reqno = ICONV_GET_DISCARD_ILSEQ;
                 ^
Iconv.xs:364:11: error: use of undeclared identifier 'ICONV_SET_TRANSLITERATE'
         reqno = ICONV_SET_TRANSLITERATE;
                 ^
Iconv.xs:366:11: error: use of undeclared identifier 'ICONV_SET_DISCARD_ILSEQ'
         reqno = ICONV_SET_DISCARD_ILSEQ;
                 ^
1 warning and 5 errors generated.
*** [Iconv.o] Error code 1

make[1]: stopped in /usr/ports/converters/p5-Text-Iconv/work/Text-Iconv-1.7

make[1]: stopped in /usr/ports/converters/p5-Text-Iconv/work/Text-Iconv-1.7
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/converters/p5-Text-Iconv

How-To-Repeat: Attempt to install converters/p5-Text-Iconv. Fails with the same errors every time.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-24 18:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-03-24 20:11:59 UTC
Responsible Changed
From-To: perl->tijl

iconv-related issue.
Comment 3 Tom 2014-03-25 08:01:50 UTC
PR can be closed. Resolved w/ r349107.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-03-25 18:40:47 UTC
Author: tijl
Date: Tue Mar 25 18:40:44 2014
New Revision: 349168
URL: http://svnweb.freebsd.org/changeset/ports/349168
QAT: https://qat.redports.org/buildarchive/r349168/

Log:
  Instead of patching the code to use /usr/include/iconv.h replace LOCALBASE
  in CONFIGURE_ARGS with ICONV_PREFIX.  Also add CFLAGS to INC in
  CONFIGURE_ARGS to get -DLIBICONV_PLUG on FreeBSD 10 with libiconv installed.
  
  PR:		ports/187907
  Approved by:	perl (mat)

Deleted:
  head/converters/p5-Text-Iconv/files/
Modified:
  head/converters/p5-Text-Iconv/Makefile

Modified: head/converters/p5-Text-Iconv/Makefile
==============================================================================
--- head/converters/p5-Text-Iconv/Makefile	Tue Mar 25 18:26:09 2014	(r349167)
+++ head/converters/p5-Text-Iconv/Makefile	Tue Mar 25 18:40:44 2014	(r349168)
@@ -3,6 +3,7 @@
 
 PORTNAME=	Text-Iconv
 PORTVERSION=	1.7
+PORTREVISION=	1
 CATEGORIES=	converters perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-
@@ -12,16 +13,7 @@ COMMENT=	Perl interface to iconv() codes
 
 USES=		perl5 iconv
 USE_PERL5=	configure
-CONFIGURE_ARGS+=	INC="-I${LOCALBASE}/include" \
-		LIBS="-L${LOCALBASE}/lib ${ICONV_LIB}" \
-		ccflags="${CFLAGS}"
+CONFIGURE_ARGS+=INC="-I${ICONV_PREFIX}/include ${CFLAGS}" \
+		LIBS="-L${ICONV_PREFIX}/lib ${ICONV_LIB}"
 
-.include <bsd.port.pre.mk>
-
-post-patch:
-.if ${OSVERSION} >= 1000043
-	@${REINPLACE_CMD} 's|<iconv.h>|"/usr/include/iconv.h"|' \
-		${WRKSRC}/Iconv.xs
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2014-03-25 18:41:11 UTC
State Changed
From-To: open->closed

Fixed in r349168.