Qmake's default settings break our CFLAGS policy. In current state qmake adds cflags to our global ones. QMAKE_CFLAGS_RELEASE and QMAKE_CXXFLAGS_RELEASE are set to '-O2' by default So when our cflags is '-O2 -pipe -fno-strict-aliasing' after generating Makefile from pro file it is '-O2 -pipe -fno-strict-aliasing -O2' and our global cflags are tainted. QMAKE_CFLAGS_DEBUG and QMAKE_CXXFLAGS_DEBUG are set to '-g', but I think is good practice to reset them too. Fix: Patch attached with submission follows:
Maintainer of Mk/Uses, Please note that PR ports/188287 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188287 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->freebsd-kde Over to maintainer
Responsible Changed From-To: freebsd-kde->pawel Approved.
Author: pawel Date: Wed Apr 9 19:00:49 2014 New Revision: 350734 URL: http://svnweb.freebsd.org/changeset/ports/350734 QAT: https://qat.redports.org/buildarchive/r350734/ Log: Reset default qmake flags so that they don't taint our globally set CFLAGS, CXXFLAGS PR: ports/188287 Submitted by: myself Approved by: kde (makc) Modified: head/Mk/Uses/qmake.mk Modified: head/Mk/Uses/qmake.mk ============================================================================== --- head/Mk/Uses/qmake.mk Wed Apr 9 18:20:06 2014 (r350733) +++ head/Mk/Uses/qmake.mk Wed Apr 9 19:00:49 2014 (r350734) @@ -61,6 +61,10 @@ QMAKE_ARGS+= -spec ${QMAKESPEC} \ QMAKE_CFLAGS="${CFLAGS}" \ QMAKE_CXXFLAGS="${CXXFLAGS}" \ QMAKE_LFLAGS="${LDFLAGS}" \ + QMAKE_CFLAGS_DEBUG="" \ + QMAKE_CFLAGS_RELEASE="" \ + QMAKE_CXXFLAGS_DEBUG="" \ + QMAKE_CXXFLAGS_RELEASE="" \ PREFIX="${PREFIX}" .if defined(WITH_DEBUG) _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!