Bug 188463 - editors/lvim now builds ok without MAKE_JOBS_UNAFE
Summary: editors/lvim now builds ok without MAKE_JOBS_UNAFE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-11 17:40 UTC by Jia-Shiun Li
Modified: 2014-04-25 20:11 UTC (History)
0 users

See Also:


Attachments
file.diff (598 bytes, patch)
2014-04-11 17:40 UTC, Jia-Shiun Li
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia-Shiun Li 2014-04-11 17:40:00 UTC
editors/vim  was made MAKE_JOBS_UNSAFE in r275776 on Sat Jun 18 14:37:18 2011 UTC due to py_config.o.

Reference to py_config was removed in upstream changeset 3707:c03b6363492b [1] on Jul 25, 2012.

Now it builds fine without MAKE_JOBS_UNSAFE.


jsli@4cbsd:/mnt/doxygen # sysctl kern.smp.cpus hw.model
kern.smp.cpus: 4
hw.model: Intel(R) Core(TM) i5-3450 CPU @ 3.10GHz
jsli@4cbsd:/mnt/vim # time make -DBATCH MAKE_JOBS_NUMBER=16
..
link.sh: Linked fine
65.279u 10.105s 0:31.21 241.4%  34339+350k 0+505io 0pf+0w
jsli@4cbsd:/mnt/vim #


[1] https://code.google.com/p/vim/source/detail?r=c03b6363492b26c02b4f8a725a91849a1a5cf548

Fix: Remove  the line MAKE_JOBS_UNAFE.

One-line patch attached.

Patch attached with submission follows:
Comment 1 Jia-Shiun Li 2014-04-11 17:42:03 UTC
sorry, subject should be "[patch] editors/vim now builds ok without
MAKE_JOBS_UNSAFE".
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-04-12 22:39:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-04-25 20:07:00 UTC
Author: sunpoet
Date: Fri Apr 25 19:06:55 2014
New Revision: 352144
URL: http://svnweb.freebsd.org/changeset/ports/352144
QAT: https://qat.redports.org/buildarchive/r352144/

Log:
  - Remove MAKE_JOBS_UNSAFE
  
  PR:		ports/188463
  Submitted by:	Jia-Shiun Li <jiashiun@gmail.com>

Modified:
  head/editors/vim/Makefile

Modified: head/editors/vim/Makefile
==============================================================================
--- head/editors/vim/Makefile	Fri Apr 25 18:15:42 2014	(r352143)
+++ head/editors/vim/Makefile	Fri Apr 25 19:06:55 2014	(r352144)
@@ -33,7 +33,6 @@ XTERM_SAVE_DESC=	Restore xterm screen af
 
 ALL_TARGET=	# empty
 MAKE_ARGS+=	CC=${CC} CONF_ARGS="--prefix=${PREFIX} ${CSCOPE_ARG}" STRIP=${STRIP_CMD} CONF_OPT_MULTIBYTE=--enable-multibyte CONF_TERM_LIB=--with-tlib=termlib
-MAKE_JOBS_UNSAFE=	yes
 PATCH=		${LOCALBASE}/bin/gpatch
 PATCH_DIST_ARGS=--batch --directory ${WRKSRC} --forward --quiet --remove-empty-files ${PATCH_DIST_STRIP}
 REINPLACE_ARGS=	-i ''
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-04-25 20:11:17 UTC
State Changed
From-To: open->closed

Committed. Thanks!