Bug 188782 - [MAINTAINER] x11-toolkits/scintilla: update to 3.4.1
Summary: [MAINTAINER] x11-toolkits/scintilla: update to 3.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-19 04:30 UTC by Naram Qashat
Modified: 2014-04-23 09:50 UTC (History)
0 users

See Also:


Attachments
scintilla-3.4.1.patch (920 bytes, patch)
2014-04-19 04:30 UTC, Naram Qashat
no flags Details | Diff
scintilla.diff (1.10 KB, patch)
2014-04-23 01:33 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2014-04-19 04:30:00 UTC
- Update to 3.4.1

Generated with FreeBSD Port Tools 1.00.2014.03.23 (mode: update, diff: SVN)
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2014-04-22 22:33:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2014-04-23 01:33:27 UTC
Hi,

Thanks for the update.

I have noticed the ports uses a != line in the Makefile, which should be
avoided.

I converted it to USES=compiler, leveraging the COMPILER_TYPE variable.

Can you approve this change (patch attached)

Thanks in advance.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Naram Qashat 2014-04-23 08:01:36 UTC
On 04/22/14 20:33, Guido Falsi wrote:
> Hi,
>
> Thanks for the update.
>
> I have noticed the ports uses a != line in the Makefile, which should be
> avoided.
>
> I converted it to USES=compiler, leveraging the COMPILER_TYPE variable.
>
> Can you approve this change (patch attached)
>
> Thanks in advance.

The patch is good to me, go right ahead.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-04-23 09:43:11 UTC
Author: madpilot
Date: Wed Apr 23 08:43:07 2014
New Revision: 351916
URL: http://svnweb.freebsd.org/changeset/ports/351916
QAT: https://qat.redports.org/buildarchive/r351916/

Log:
  - Update to 3.4.1
  - in x11-toolkits/scintilla, leverage USES=compiler to check if
    we're on clang or gcc
  
  PR:		ports/188782, ports/188783
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Modified:
  head/editors/scite/Makefile
  head/editors/scite/distinfo
  head/x11-toolkits/scintilla/Makefile
  head/x11-toolkits/scintilla/distinfo

Modified: head/editors/scite/Makefile
==============================================================================
--- head/editors/scite/Makefile	Wed Apr 23 08:29:23 2014	(r351915)
+++ head/editors/scite/Makefile	Wed Apr 23 08:43:07 2014	(r351916)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	scite
-PORTVERSION=	3.3.9
+PORTVERSION=	3.4.1
 CATEGORIES=	editors gnome
 MASTER_SITES=	SF/scintilla/SciTE/${PORTVERSION}
 DISTNAME=	${PORTNAME}${PORTVERSION:S/.//g}

Modified: head/editors/scite/distinfo
==============================================================================
--- head/editors/scite/distinfo	Wed Apr 23 08:29:23 2014	(r351915)
+++ head/editors/scite/distinfo	Wed Apr 23 08:43:07 2014	(r351916)
@@ -1,2 +1,2 @@
-SHA256 (scite339.tgz) = cd7bdfdf8cd870893375519405510417145ec0a9790ed7209f21d552d36c0775
-SIZE (scite339.tgz) = 2229269
+SHA256 (scite341.tgz) = ab2940ba6ad3f1c7c33aea233dd5b44efc75319062fe0b3625db04c747bf3341
+SIZE (scite341.tgz) = 2237159

Modified: head/x11-toolkits/scintilla/Makefile
==============================================================================
--- head/x11-toolkits/scintilla/Makefile	Wed Apr 23 08:29:23 2014	(r351915)
+++ head/x11-toolkits/scintilla/Makefile	Wed Apr 23 08:43:07 2014	(r351916)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	scintilla
-PORTVERSION=	3.3.9
+PORTVERSION=	3.4.1
 CATEGORIES=	x11-toolkits
 MASTER_SITES=	SF/scintilla/SciTE/${PORTVERSION}
 DISTNAME=	scite${PORTVERSION:S/.//g}
@@ -13,7 +13,7 @@ COMMENT=	Full-featured free source code 
 
 WRKSRC=		${WRKDIR}/${PORTNAME}/gtk
 
-USES=		gmake iconv pkgconfig
+USES=		compiler gmake iconv pkgconfig
 MAKEFILE=	makefile
 USE_LDCONFIG=	yes
 USE_GNOME=	gtk20
@@ -28,9 +28,7 @@ PICFLAG?=	-fPIC
 PICFLAG?=	-fpic
 .endif
 
-CCISCLANG!=     ${CC} --version
-
-.if empty(CCISCLANG:M*clang*)
+.if ! ${COMPILER_TYPE:Mclang}
 CPPSTDRE=	-e 's|--std=c++0x||'
 .else
 CPPSTDRE=	

Modified: head/x11-toolkits/scintilla/distinfo
==============================================================================
--- head/x11-toolkits/scintilla/distinfo	Wed Apr 23 08:29:23 2014	(r351915)
+++ head/x11-toolkits/scintilla/distinfo	Wed Apr 23 08:43:07 2014	(r351916)
@@ -1,2 +1,2 @@
-SHA256 (scite339.tgz) = cd7bdfdf8cd870893375519405510417145ec0a9790ed7209f21d552d36c0775
-SIZE (scite339.tgz) = 2229269
+SHA256 (scite341.tgz) = ab2940ba6ad3f1c7c33aea233dd5b44efc75319062fe0b3625db04c747bf3341
+SIZE (scite341.tgz) = 2237159
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2014-04-23 09:43:34 UTC
State Changed
From-To: open->closed

Committed. Thanks!