Bug 189050 - [PATCH] games/oneko fails to build with Clang
Summary: [PATCH] games/oneko fails to build with Clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-27 16:40 UTC by A.J. "Fonz" van Werven
Modified: 2014-06-05 21:36 UTC (History)
2 users (show)

See Also:

Attachments
file.diff (200 bytes, patch)
2014-04-27 16:40 UTC, A.J. "Fonz" van Werven 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description A.J. "Fonz" van Werven 2014-04-27 16:40:02 UTC 
The games/oneko port fails to build on FreeBSD 9.1-RELEASE-p3/amd64, if Clang is used as the compiler.

The function NekoChangeVisibility() in event.c does not have a return type specified. It is therefore assumed to return int, while it doesn't actually return anything. Explicitly specifying this function to be of type void fixes the problem.

Fix: Apply the supplied patch to event.c.

Please note: the port's Makefile explicitly specifies a do-patch target, so the Makefile will probably have to be updated as well, in order to make sure the patch actually gets applied.

Patch attached with submission follows:
How-To-Repeat: # portmaster games/oneko
(On a system that uses Clang, I didn't try with GCC.)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-27 16:40:05 UTC 
Maintainer of games/oneko,

Please note that PR ports/189050 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189050

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-27 16:40:06 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2014-06-04 22:15:22 UTC 
maintainer timeout
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2014-06-05 21:36:00 UTC 
Commited, Thanks!

Sorry if this took so long.