Bug 189069 - [patch] devel/libpdel: Fix build on current, do not require root and modernize
Summary: [patch] devel/libpdel: Fix build on current, do not require root and modernize
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-28 12:50 UTC by Renato Botelho
Modified: 2014-05-14 19:30 UTC (History)
0 users

See Also:


Attachments
file.diff (2.58 KB, patch)
2014-04-28 12:50 UTC, Renato Botelho
no flags Details | Diff
libpdel.diff (3.15 KB, patch)
2014-04-28 12:55 UTC, Renato Botelho
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer freebsd_triage 2014-04-28 12:50:00 UTC
- Fix build with recent current after removal of RTM_OLDADD and RTM_OLDDEL
- Modernize LIB_DEPENDS syntax
- Do not require root for staging
- Bump PORTREVISION because of LIB_DEPENDS change

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-28 12:50:02 UTC
Maintainer of devel/libpdel,

Please note that PR ports/189069 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189069

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-28 12:50:03 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2014-04-28 12:55:46 UTC
Here is a new patch version, with a missed change on patch-arp

-- 
Renato Botelho <garga     @ FreeBSD.org>
               <garga.bsd @ gmail.com>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2014-04-28 12:55:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

y
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-05-14 19:29:32 UTC
Author: garga
Date: Wed May 14 18:29:25 2014
New Revision: 354083
URL: http://svnweb.freebsd.org/changeset/ports/354083
QAT: https://qat.redports.org/buildarchive/r354083/

Log:
  . Fix build with recent current after removal of RTM_OLDADD and RTM_OLDDEL
  . Modernize LIB_DEPENDS syntax
  . Do not require root for staging
  . Bump PORTREVISION because of LIB_DEPENDS change
  
  PR:		ports/189069
  Approved by:	maintainer timeout (> 2 weeks)

Added:
  head/devel/libpdel/files/patch-Makefile   (contents, props changed)
  head/devel/libpdel/files/patch-net__route_msg.c   (contents, props changed)
Modified:
  head/devel/libpdel/Makefile
  head/devel/libpdel/files/patch-arp

Modified: head/devel/libpdel/Makefile
==============================================================================
--- head/devel/libpdel/Makefile	Wed May 14 17:56:47 2014	(r354082)
+++ head/devel/libpdel/Makefile	Wed May 14 18:29:25 2014	(r354083)
@@ -3,14 +3,14 @@
 
 PORTNAME=	libpdel
 PORTVERSION=	0.5.3
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	devel net www
 MASTER_SITES=	LOCAL/archie
 
 MAINTAINER=	mav@alkar.net
 COMMENT=	Packet Design multi-purpose C library for embedded applications
 
-LIB_DEPENDS=	expat.6:${PORTSDIR}/textproc/expat2
+LIB_DEPENDS=	libexpat.so:${PORTSDIR}/textproc/expat2
 MAKE_ENV=	WITHOUT_PROFILE=yes __MAKE_CONF=/dev/null SRCCONF=/dev/null
 
 USE_LDCONFIG=	yes

Added: head/devel/libpdel/files/patch-Makefile
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/libpdel/files/patch-Makefile	Wed May 14 18:29:25 2014	(r354083)
@@ -0,0 +1,14 @@
+--- Makefile.orig	2014-04-26 19:31:00.000000000 -0300
++++ Makefile	2014-04-26 19:31:40.000000000 -0300
+@@ -2,6 +2,11 @@
+ 
+ LIB=		pdel
+ 
++BINOWN!=	/usr/bin/id -n -u
++BINGRP!=	/usr/bin/id -n -g
++SHAREOWN=	${BINOWN}
++SHAREGRP=	${BINGRP}
++
+ SUBDIRS=	config http io net ppp structs sys tmpl util
+ 
+ VERSION!=	grep -w PDEL_VERSION_STRING ${.CURDIR}/version.h \

Modified: head/devel/libpdel/files/patch-arp
==============================================================================
--- head/devel/libpdel/files/patch-arp	Wed May 14 17:56:47 2014	(r354082)
+++ head/devel/libpdel/files/patch-arp	Wed May 14 18:29:25 2014	(r354083)
@@ -16,7 +16,7 @@
  
  struct route_flag {
  	const char	*name;
-@@ -92,15 +98,21 @@ static const	struct route_flag route_fla
+@@ -92,15 +98,23 @@ static const	struct route_flag route_fla
  	FLAG(DYNAMIC),
  	FLAG(MODIFIED),
  	FLAG(DONE),
@@ -31,7 +31,9 @@
  	FLAG(BLACKHOLE),
  	FLAG(PROTO2),
  	FLAG(PROTO1),
++#ifdef RTF_PRCLONING
  	FLAG(PRCLONING),
++#endif
 +#ifdef RTF_WASCLONED
  	FLAG(WASCLONED),
 +#endif

Added: head/devel/libpdel/files/patch-net__route_msg.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/libpdel/files/patch-net__route_msg.c	Wed May 14 18:29:25 2014	(r354083)
@@ -0,0 +1,15 @@
+--- net/route_msg.c.orig	2014-04-26 19:28:21.000000000 -0300
++++ net/route_msg.c	2014-04-26 19:28:57.000000000 -0300
+@@ -608,8 +608,12 @@
+ 	case RTM_REDIRECT:	typestr = "REDIRECT"; break;
+ 	case RTM_MISS:		typestr = "MISS"; break;
+ 	case RTM_LOCK:		typestr = "LOCK"; break;
++#ifdef RTM_OLDADD
+ 	case RTM_OLDADD:	typestr = "OLDADD"; break;
++#endif
++#ifdef RTM_OLDDEL
+ 	case RTM_OLDDEL:	typestr = "OLDDEL"; break;
++#endif
+ 	case RTM_RESOLVE:	typestr = "RESOLVE"; break;
+ 	case RTM_NEWADDR:	typestr = "NEWADDR"; break;
+ 	case RTM_DELADDR:	typestr = "DELADDR"; break;
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Renato Botelho freebsd_committer freebsd_triage 2014-05-14 19:29:35 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!