Bug 189098 - [NEW PORT] www/pycarddav: A simple to use CardDAV CLI client.
Summary: [NEW PORT] www/pycarddav: A simple to use CardDAV CLI client.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 08:10 UTC by Samir Noir
Modified: 2015-01-18 08:38 UTC (History)
1 user (show)

See Also:


Attachments
pycarddav.shar (2.90 KB, application/x-shar)
2014-04-29 09:11 UTC, Samir Noir
no flags Details
pycarddav port corrections (2.44 KB, patch)
2014-08-31 12:29 UTC, Samir Noir
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samir Noir 2014-04-29 08:10:00 UTC

    
Comment 1 Samir Noir 2014-04-29 09:11:23 UTC
Sorry about the formatting (description in environment) and for the
missing shar (attach here).
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-16 23:30:07 UTC
I'll take it, review pending
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-23 01:31:23 UTC
Hi Samir, thanks for your submission :)

Review:

- Include portlint output (pass or warnings)
- Create an account at redports to build test/QA future submissions,
  and provide the build log URL when you submit them

- Use CHEESESHOP for MASTER_SITES, or
  USE_GITHUB for distribution files

- RUN_DEPENDS:py-sqlite3 - I don't see sqlite in   
  setup.py:install_requires, why it is required here?
- pkg-descr: Strip trailing-slash from WWW: URL

Please submit a second version of your changes, and let me know if you have any questions :)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-08-30 03:54:36 UTC
Feedback timeout by maintainer for new port pending updated patch.

Anyone may re-open this issue to provide the requested changes (and take maintainership if necessary(
Comment 5 Samir Noir 2014-08-31 12:29:17 UTC
Created attachment 146592 [details]
pycarddav port corrections
Comment 6 Samir Noir 2014-08-31 12:30:02 UTC
Sorry about the lag, in attachment the updated patch :

- Use CHEESESHOP in MASTER_SITES
- Use USES and USE_PYTHON
- Correct RUN_DEPENDS (port version)
- Change WWW url in pkg-descr (removing the trailing slash)
- distinfo checksum and size

Test suite :
- port test : OK
- portlint : OK
- poudriere testport : OK

Redports logs : https://redports.org//~samir/20140831105200-59632-239202/py27-pycarddav-0.7.0.log

py-sqlite3 is not in the install_requires of setup.py because sqlite is a part of the Python standard library, but this is not the case under FreeBSD (sqlite is provided in a separate port).
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-01-18 08:35:20 UTC
A commit references this bug:

Author: koobs
Date: Sun Jan 18 08:35:13 UTC 2015
New revision: 377285
URL: https://svnweb.freebsd.org/changeset/ports/377285

Log:
  [NEW] www/pycarddav: Simple to use CardDAV CLI client

  pyCardDAV is a simple to use CardDAV CLI client. It has built in support for
  mutt's query_command but also works very well solo (and with other MUAs).

  pyCardDAV consists of pycardsyncer, a program for syncing your CardDAV
  resource into a local database and of pc_query, a program for querying the
  local database.

  Features:

    * Tested against davical, owncloud and sabredav
    * Import the sender's address directly from mutt
    * Add email addresses directly from mutt
    * Backup and import to and from .vcf files

  WWW: http://lostpackets.de/pycarddav

  PR:		189098 (with changes)
  Submitted by:	Samir Noir <samir noir im>

Changes:
  head/www/Makefile
  head/www/pycarddav/
  head/www/pycarddav/Makefile
  head/www/pycarddav/distinfo
  head/www/pycarddav/files/
  head/www/pycarddav/files/pkg-message.in
  head/www/pycarddav/pkg-descr
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-18 08:38:09 UTC
Committed with minor changes, apologies for the delay and thank you Samir!