Bug 189176 - lang/ocaml: DEF_OPT option interacts poorly with camlp4
Summary: lang/ocaml: DEF_OPT option interacts poorly with camlp4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-01 10:50 UTC by Michael Grünewald
Modified: 2014-06-10 23:42 UTC (History)
0 users

See Also:

Attachments
lang-ocaml.patch (2.33 KB, patch)
2014-06-10 22:57 UTC, Michael Grünewald 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Grünewald 2014-05-01 10:50:00 UTC 
Anil Madhavapeddy reported:

> The DEF_OPT patch that swaps out camlp4o.opt with camlp4o breaks a lot of OCaml builds, since camlp4 dynamically loads in syntax extension modules that are  different in bytecode (.cma) and native code (.cmxs).

> It would be safer to remove camlp4 from the MODOPT substitution list, or remove the entire option. Most build systems will look for the .opt version of the compiler these days anyway (such as OASIS).

> I've had at least one user report a failure that turned out to be due to DEF_OPT; https://github.com/ocaml/opam/issues/1044

I (maintainer) would opt to phase out the DEF_OPT option and will soon submit a patch.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-01 10:50:10 UTC 
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Michael Grünewald 2014-05-08 09:47:25 UTC 
I prepared a patch to fix this. I will submit together with the patch
for ports/189063 which also updates lang/ocaml. That patch is ready and
the last tests are on the way.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-05-10 19:26:43 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->marino

I'll take it.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-06-06 13:03:10 UTC 
and the patch is where?
Comment 5 Michael Grünewald 2014-06-10 22:57:52 UTC 
Created attachment 143655 [details]
lang-ocaml.patch

Since our work on 189063 needs more time than we estimated, we will need to solve that issue separately.  Here is a patch for this (189176) one.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-06-10 23:11:01 UTC 
I'm confused.
lang-ocaml.patch, which you just uploaded, seems to be a patch to math/ocamlgsl, not lang/ocaml.

Mistake?
Comment 7 Michael Grünewald 2014-06-10 23:28:56 UTC 
Attachment 143655 [details] starts with

  diff --git a/lang/ocaml/Makefile b/lang/ocaml/Makefile
  index 0ff58d7..227c642 100644
  --- a/lang/ocaml/Makefile
  +++ b/lang/ocaml/Makefile

It does not look like a patch to math/ocamlgsl. Or am I missing something?
Comment 8 John Marino freebsd_committer freebsd_triage 2014-06-10 23:30:44 UTC 
it did, but it doesn't anymore.  weird.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-06-10 23:41:00 UTC 
A commit references this bug:

Author: marino
Date: Tue Jun 10 23:40:38 UTC 2014
New revision: 357402
URL: http://svnweb.freebsd.org/changeset/ports/357402

Log:
  lang/ocaml: Remove DEF_OPT option (non-default option)

  The option reacts poorly with ocamlp4, and phasing out DEF_OPT
  completely will prevent a lot of breakage with ports that also
  interact with ocamlp4.

  PR:		189176
  Submitted by:	Anil Madhavapeddy
  Prepared by:	maintainer (Michael Gruenewald)

Changes:
  head/lang/ocaml/Makefile
  head/lang/ocaml/files/patch-camlp4-man_Makefile