Bug 189370 - net-mgmt/check_mysql_health useless under perl5-5.16.3_4
Summary: net-mgmt/check_mysql_health useless under perl5-5.16.3_4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 13:10 UTC by Pavel
Modified: 2014-12-10 13:34 UTC (History)
2 users (show)

See Also:

Attachments
fix ports warnings (4.86 KB, patch)
2014-12-08 00:00 UTC, Rodrigo Osorio 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel 2014-05-05 13:10:00 UTC 
Use of qw(...) as parentheses is deprecated at /usr/local/libexec/nagios/check_mysql_health line 1247.
Use of qw(...) as parentheses is deprecated at /usr/local/libexec/nagios/check_mysql_health line 2596.
Use of qw(...) as parentheses is deprecated at /usr/local/libexec/nagios/check_mysql_health line 3473.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-05 13:10:11 UTC 
Maintainer of net-mgmt/check_mysql_health,

Please note that PR ports/189370 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189370

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-05 13:10:12 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 John Marino freebsd_committer freebsd_triage 2014-07-25 13:42:53 UTC 
pinging maintainer again...
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2014-12-05 16:42:23 UTC 
cherry picking PRs
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2014-12-08 00:00:26 UTC 
Created attachment 150328 [details]
fix ports warnings

fix patch
bump port revision
move license to make portlint happy
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2014-12-08 00:04:49 UTC 
After few investigations it appears that :
- the incorrect outputs are only warnings
- the warnings was introduced in perl 5.16 to track some kind of inconsistence
- it's easy to fix

I push a patch to fix it, so please try it and give me a feedback

btw, maintainer approval is required in order to commit the patch

- rodrigo
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-12-10 13:33:15 UTC 
A commit references this bug:

Author: rodrigo
Date: Wed Dec 10 13:32:31 UTC 2014
New revision: 374455
URL: https://svnweb.freebsd.org/changeset/ports/374455

Log:
  Fix warnings when run check_mysql_health with perl >= 5.16
  Remove unnecessary dirs from plist

  PR:		ports/189370
  Submitted by:	rodrigo

Changes:
  head/net-mgmt/check_mysql_health/Makefile
  head/net-mgmt/check_mysql_health/files/
  head/net-mgmt/check_mysql_health/files/patch-plugins-scripts_Nagios_DBD_MySQL_Cluster.pm
  head/net-mgmt/check_mysql_health/files/patch-plugins-scripts_Nagios_DBD_MySQL_Server.pm
  head/net-mgmt/check_mysql_health/files/patch-plugins-scripts_check_mysql_health.pl
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2014-12-10 13:34:33 UTC 
Committed after maintainer and reporter timeout