Bug 189438 - [PATCH] devel/ode: staging, fixes
Summary: [PATCH] devel/ode: staging, fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-07 20:30 UTC by Dmitry Marakasov
Modified: 2014-05-12 00:10 UTC (History)
1 user (show)

See Also:


Attachments
ode-0.11.1.patch (2.50 KB, patch)
2014-05-07 20:30 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2014-05-07 20:30:02 UTC
- Add LICENSE
- Support staging
- Convert USE_BZIP2 and USE_GMAKE to USES
- Add USES=libtool
- Use new OPTIONS features

All ode consumer ports build fine with these changes.

Port maintainer (acm@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-07 20:30:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->acm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-05-12 00:02:28 UTC
Author: amdmi3
Date: Sun May 11 23:02:23 2014
New Revision: 353745
URL: http://svnweb.freebsd.org/changeset/ports/353745
QAT: https://qat.redports.org/buildarchive/r353745/

Log:
  - Support staging
  - Convert USE_BZIP2 to USES
  - Convert USE_GMAKE to USES
  - Add USES=libtool, drop .la file
  - Add LICENSE
  - Use new OPTIONS features
  - Fix checking for illegal options combination
  
  PR:		189438
  Submitted by:	amdmi3
  Approved by:	portmgr blanket

Modified:
  head/devel/ode/Makefile
  head/devel/ode/pkg-plist

Modified: head/devel/ode/Makefile
==============================================================================
--- head/devel/ode/Makefile	Sun May 11 22:50:31 2014	(r353744)
+++ head/devel/ode/Makefile	Sun May 11 23:02:23 2014	(r353745)
@@ -3,6 +3,7 @@
 
 PORTNAME=	ode
 PORTVERSION=	0.11.1
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel
 MASTER_SITES=	SF/opende/ODE/${PORTVERSION}
@@ -10,53 +11,39 @@ MASTER_SITES=	SF/opende/ODE/${PORTVERSIO
 MAINTAINER=	acm@FreeBSD.org
 COMMENT=	Articulated rigid body dynamics library
 
+LICENSE=	LGPL21 BSD3CLAUSE
+LICENSE_COMB=	dual
+
 CONFLICTS=	ode-devel-[0-9].*
 
-USE_BZIP2=	yes
+USES=		tar:bzip2 gmake libtool
 USE_GL=		yes
-USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 
-CONFIGURE_ENV=	LIBS="-L${LOCALBASE}/lib"
-
-OPTIONS_DEFINE=	GIMPACT GYROSCOPIC DOUBLE OU
+OPTIONS_DEFINE=		GIMPACT GYROSCOPIC DOUBLE OU
 OPTIONS_DEFAULT=	GYROSCOPIC
+
 GIMPACT_DESC=		Enable gimpact instead of opcode support
 GYROSCOPIC_DESC=	Configure ODE to work with gyroscopic term
 DOUBLE_DESC=		Enable double precision (BROKEN with GIMPACT)
 OU_DESC=		Enable Thread-local storage (Experimental)
 
+GIMPACT_CONFIGURE_ON=	--with-trimesh=gimpact
+GIMPACT_CONFIGURE_OFF=	--with-trimesh=opcode
+GYROSCOPIC_CONFIGURE_ENABLE=	gyroscopic
+DOUBLE_CONFIGURE_ENABLE=	double-precision
+OU_CONFIGURE_ENABLE=		ou
+
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
-NO_STAGE=	yes
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == "amd64" || ${ARCH} == "ia64"
 CFLAGS+=	-fPIC -DPIC
 .endif
 
-.if ${PORT_OPTIONS:MGIMPACT} && defined(WITH_DOUBLE)
-IGNORE=	currently double precision is not supported by gimpact
-.endif
-
-.if ! ${PORT_OPTIONS:MGIMPACT}
-CONFIGURE_ARGS+=	--with-trimesh=opcode
-.else
-CONFIGURE_ARGS+=	--with-trimesh=gimpact
-.endif
-
-.if ! ${PORT_OPTIONS:MGYROSCOPIC}
-CONFIGURE_ARGS+=	--disable-gyroscopic
-.endif
-
-.if ${PORT_OPTIONS:MDOUBLE}
-CONFIGURE_ARGS+=	--enable-double-precision
-.endif
-
-.if ${PORT_OPTIONS:MOU}
-CONFIGURE_ARGS+=	--enable-ou
-.else
-CONFIGURE_ARGS+=	--disable-ou
+.if ${PORT_OPTIONS:MGIMPACT} && ${PORT_OPTIONS:MDOUBLE}
+IGNORE=		currently double precision is not supported by gimpact
 .endif
 
 post-patch:
@@ -75,6 +62,6 @@ post-patch:
 
 post-install:
 	${SED} -e '/PACKAGE/ s|^|//|; /VERSION/ s|^|//|' ${WRKSRC}/ode/src/config.h \
-		> ${PREFIX}/include/ode/config.h
+		> ${STAGEDIR}${PREFIX}/include/ode/config.h
 
 .include <bsd.port.post.mk>

Modified: head/devel/ode/pkg-plist
==============================================================================
--- head/devel/ode/pkg-plist	Sun May 11 22:50:31 2014	(r353744)
+++ head/devel/ode/pkg-plist	Sun May 11 23:02:23 2014	(r353745)
@@ -22,6 +22,5 @@ include/ode/odemath.h
 include/ode/rotation.h
 include/ode/timer.h
 lib/libode.a
-lib/libode.la
 libdata/pkgconfig/ode.pc
 @dirrm include/ode
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2014-05-12 00:02:46 UTC
State Changed
From-To: open->closed

Committed. Thanks!