Bug 189622 - [MAINTAINER UPDATE] audio/lingot add stagging
Summary: [MAINTAINER UPDATE] audio/lingot add stagging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-10 19:40 UTC by Loïc Bartoletti
Modified: 2014-07-02 14:09 UTC (History)
3 users (show)

See Also:


Attachments
file.diff (3.35 KB, patch)
2014-05-10 19:40 UTC, Loïc Bartoletti
no flags Details | Diff
Support staging (6.09 KB, patch)
2014-06-19 03:55 UTC, Jason E. Hale
jhale: maintainer-approval? (lbartoletti)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2014-05-10 19:40:00 UTC
Add staging

Fix: Patch attached with submission follows:
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-05-10 23:53:44 UTC
Hi,

You shouldn't need to remove the locale directories in pkg-plist,
they're in ${PORTSDIR}/Templates/BSD.local.dist and are handled
automatically.

Additionally, you should be able to use @dirrm instead of @dirrmtry for
directories that your port creates, such as %%DATADIR%% and its
children.
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2014-05-13 06:31:16 UTC
Hi,

It's a success for FreeBSD > 9.x
(https://redports.org/buildarchive/20140513044800-42455/)
But leftovers with FreeBSD 9.x

Best Regards

Last test : https://svn.redports.org/lbartoletti/audio/lingot/

On 11.05.2014 00:53, Raphael Kubo da Costa wrote:
> Hi,
>
> You shouldn't need to remove the locale directories in pkg-plist,
> they're in ${PORTSDIR}/Templates/BSD.local.dist and are handled
> automatically.
>
> Additionally, you should be able to use @dirrm instead of @dirrmtry for
> directories that your port creates, such as %%DATADIR%% and its
> children.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-18 22:53:27 UTC
Is there an updated patch coming or ?
What's going on with this bug report, it looks stalled.
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2014-06-19 03:55:31 UTC
Created attachment 143918 [details]
Support staging

The main problem is that the locale data is installed in lib instead of share.

This diff fixes that.  It also:
- Simplifies MASTER_SITES
- Uses options helpers
- Removes patch for unsupported versions of FreeBSD
- Prevents the installation of some unneeded and 0 length files
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2014-07-02 14:09:59 UTC
Committed my version of the patch in r360185.