- Disable broken SDL interface - Add Link support - Add Lirc support Full commit log at http://sourceforge.net/p/vbam/code/1231/log/ Fix: Patch attached with submission follows:
Hi, Patching the makefile reject, could u please recreate a new patch against the current ports tree. thank you.
Created attachment 143817 [details] Updated regenrated r1231 patch Since r1001: - Add Link support - Add Lirc support - Patch SDL interface (thanks dennylin93@hs.ntnu.edu.tw) - Several new translations - Many small fixes for various titles Full commit log at http://sourceforge.net/p/vbam/code/1231/log/
i think I promised to take this...
Hi Nicole, It is failing plist-sanity checks: https://redports.org/buildarchive/20140618231835-77896/ It looks like a simple plist issue. Can you provide a "delta" patch? I assume only a patch to plist is needed.
That's something I was mulling over actually. makeplist is giving me dirrmtrys for those two locale dirs: Error: Orphaned: @dirrmtry share/locale/ca_ES/LC_MESSAGES Error: Orphaned: @dirrmtry share/locale/ca_ES Error: Orphaned: @dirrmtry share/locale/it_IT/LC_MESSAGES Error: Orphaned: @dirrmtry share/locale/it_IT But the build failure is exactly the opposite problem, those dirs specified in the plist but not on the filesystem: pkg-static: lstat(/work/a/ports/emulators/visualboyadvance-m/work/stage/usr/local/share/locale/ca_ES/LC_MESSAGES/): No such file or directory pkg-static: lstat(/work/a/ports/emulators/visualboyadvance-m/work/stage/usr/local/share/locale/ca_ES/): No such file or directory pkg-static: lstat(/work/a/ports/emulators/visualboyadvance-m/work/stage/usr/local/share/locale/it_IT/LC_MESSAGES/): No such file or directory pkg-static: lstat(/work/a/ports/emulators/visualboyadvance-m/work/stage/usr/local/share/locale/it_IT/): No such file or directory I will attach the patch again with those four lines removed and see what redports thinks of it. This looks like something I should start using myself :)
Created attachment 143947 [details] VBAM r1231 update without LC_MESSAGES in plist VBAM r1231 update without LC_MESSAGES in plist due to buildbot failure
If I were to guess on the original diff, it's because the file is install with the prefix "%%GVBAM%%%%NLS%" but the dirrmtry is prefixed only with "%%NLS%%" rather than "%%GVBAM%%%%NLS%". I'll try adding that the dirrmtry line and see if that fixes things.
hypothesis confirmed, redports likes that. I'll commit this shortly.
A commit references this bug: Author: marino Date: Fri Jun 20 10:20:19 UTC 2014 New revision: 358546 URL: http://svnweb.freebsd.org/changeset/ports/358546 Log: emulators/visualboyadvance-m: Upgrade version r1001 => r1231 Improvements: * Add Link support * Add Lirc support * Patch SDL interface (thanks dennylin93) * Several new translations * Many small fixes to various titles PR: 189647 Submitted by: maintainer (Nicole Reid) Changes: head/emulators/visualboyadvance-m/Makefile head/emulators/visualboyadvance-m/distinfo head/emulators/visualboyadvance-m/files/patch-CMakeLists.txt head/emulators/visualboyadvance-m/files/patch-fex-fex-Data_Reader.cpp head/emulators/visualboyadvance-m/files/patch-src-Util.cpp head/emulators/visualboyadvance-m/files/patch-src-common-ffmpeg.cpp head/emulators/visualboyadvance-m/files/patch-src-gba-GBALink.cpp head/emulators/visualboyadvance-m/files/patch-src-gtk-filters.cpp head/emulators/visualboyadvance-m/files/patch-src-gtk-filters.h head/emulators/visualboyadvance-m/files/patch-src-gtk-gvbam.desktop head/emulators/visualboyadvance-m/files/patch-src-sdl-expr.cpp head/emulators/visualboyadvance-m/pkg-plist
Thanks for hanging in there.