- shebangfix - Add LICENSE to the Makefile Summary: Fix problems preventing it building with DEVELOPER=yes and port test "port test" still fails when checking for plist orphans, but that's a problem with the build system not provding a way to ignore paths owned by perl rather than a perl module. It's clean other than that (with my perl.mk patch from ports/189694 applied). Port maintainer (perl@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Responsible Changed From-To: freebsd-ports-bugs->perl Over to maintainer (via the GNATS Auto Assign Tool)
Hello. You can don't use WRKSRC inside SHEBANG_FILES. According ports/Mk/Uses/sheb= angfix.mk there=20 fix-shebang: @cd ${WRKSRC}; \ ${ECHO_CMD} ${SHEBANG_FILES} | ${XARGS} ${SED} -i '' ${_SHE= BANG_REINPLACE_ARGS}
I don't see anything prohibiting the use of WRKSRC inside SHEBANG_FILES. Normally it would be redundant, but I used it in this instance to silence a false positive warning from portlint. Including it gives the correct result _and_ silences a false warning.
Sure, as you wish.
An updated patch for this, as I've discovered how to make "port test" happy about the directories deliberately omitted from the pkg-plist (the ones owned by the lang/perl5.x package). --- p5-Mail-DKIM-0.40.patch begins here --- Index: Makefile =================================================================== --- Makefile (revision 353783) +++ Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= Mail-DKIM PORTVERSION= 0.40 +PORTREVISION= 1 CATEGORIES= mail perl5 MASTER_SITES= CPAN PKGNAMEPREFIX= p5- @@ -10,6 +11,9 @@ MAINTAINER= perl@FreeBSD.org COMMENT= Perl5 module to process and/or create DKIM email +LICENSE= ART10 GPLv1 +LICENSE_COMB= dual + RUN_DEPENDS= p5-Crypt-OpenSSL-RSA>=0:${PORTSDIR}/security/p5-Crypt-OpenSSL-RSA \ p5-Net-DNS>=0:${PORTSDIR}/dns/p5-Net-DNS \ p5-Mail-Tools>=0:${PORTSDIR}/mail/p5-Mail-Tools @@ -17,9 +21,12 @@ MASTER_SITE_BACKUP+= http://jason.long.name/dkimproxy/ -USES= perl5 +USES= perl5 shebangfix USE_PERL5= configure +# Prefixed with ${WRKSRC} to silence portlint false positive warning about ${SCRIPTDIR} +SHEBANG_FILES= ${WRKSRC}/scripts/dkim*.pl + post-install: ${INSTALL_SCRIPT} ${WRKSRC}/scripts/dkim*.pl ${STAGEDIR}${PREFIX}/bin Index: pkg-plist =================================================================== --- pkg-plist (revision 353783) +++ pkg-plist (working copy) @@ -55,3 +55,15 @@ @dirrmtry %%SITE_PERL%%/Mail/DKIM/Algorithm @dirrmtry %%SITE_PERL%%/Mail/DKIM @dirrmtry %%SITE_PERL%%/Mail + +@comment Don't remove these directories, even if empty +@comment They belong to the lang/perl5.* package, not the module +@comment Including them as comments makes "port test" happy +@comment @dirrmtry %%PERL5_MAN3%% +@comment @dirrmtry lib/perl5/%%PERL_VER%%/man +@comment @dirrmtry lib/perl5/%%PERL_VER%% +@comment @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto +@comment @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%% +@comment @dirrmtry %%SITE_PERL%% +@comment @dirrmtry lib/perl5/site_perl +@comment @dirrmtry lib/perl5 --- p5-Mail-DKIM-0.40.patch ends here ---
A commit references this bug: Author: sunpoet Date: Fri Feb 27 12:49:51 UTC 2015 New revision: 380082 URL: https://svnweb.freebsd.org/changeset/ports/380082 Log: - Add LICENSE [1] - Sort *_DEPENDS - Merge MASTER_SITE_BACKUP to MASTER_SITES PR: 189695 [1] Submitted by: <paul@inetstat.net> [1] Changes: head/mail/p5-Mail-DKIM/Makefile
Committed. Thanks!