Bug 189894 - [Maintainer update] sysutils/qjail2 stage added.
Summary: [Maintainer update] sysutils/qjail2 stage added.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-17 19:10 UTC by qjail
Modified: 2014-05-25 11:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.77 KB, patch)
2014-05-17 19:10 UTC, qjail
no flags Details | Diff
qjail2.staging.diff (2.43 KB, patch)
2014-05-24 13:02 UTC, qjail
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description qjail 2014-05-17 19:10:01 UTC
Changed port Makefile to add stage support

Fix: Patch attached with submission follows:
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2014-05-18 07:46:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2014-05-19 04:42:39 UTC
State Changed
From-To: open->feedback

fails to build please check and send a new patch 
http://pkgdev.miwibox.org/data/10i386-default/2014-05-18_08h46m55s/logs/errors/qjail2-2.2.log
Comment 3 joeb1 2014-05-20 10:10:19 UTC
fails to build please check and send a new patch
http://pkgdev.miwibox.org/data/10i386-default/2014-05-18_08h46m55s/logs/erro
rs/qjail2-2.2.log


I have no idea what the error message means in the above log.
This problem is above my knowledge level.

Staging in this port qjail2 is done the same way port qjail is done and it
works there.
The un-staged qjail2 port installs fine.

When I "make stage" on staged qjail2 port, it gives this error message;

make: exec(/user/ports/sysutils/qjail2/work/stage/usr/local/bin) failed
(Permission denied)
*** Error code 1

I checked the permissions on that directory and it looks fine to me.

Need help.
Comment 4 qjail 2014-05-24 13:02:06 UTC
I kept beating on this port to get staging to work.

Those pesky tab, space, eol cause error messages in "portlint -A" that 
are so hard to understand what there referring to.

I have finally gotten staging to work. 
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-05-25 11:13:42 UTC
Author: miwi
Date: Sun May 25 10:13:38 2014
New Revision: 355156
URL: http://svnweb.freebsd.org/changeset/ports/355156
QAT: https://qat.redports.org/buildarchive/r355156/

Log:
  - Stage support
  
  PR:		189894
  Submitted by:	Joe Barbish <qjail@a1poweruser.com> (maintainer)

Modified:
  head/sysutils/qjail2/Makefile
  head/sysutils/qjail2/pkg-plist

Modified: head/sysutils/qjail2/Makefile
==============================================================================
--- head/sysutils/qjail2/Makefile	Sun May 25 10:13:09 2014	(r355155)
+++ head/sysutils/qjail2/Makefile	Sun May 25 10:13:38 2014	(r355156)
@@ -5,41 +5,40 @@ PORTNAME=	qjail
 PORTVERSION=	2.2
 CATEGORIES=	sysutils
 MASTER_SITES=	SF/${PORTNAME}
+PKGNAMESUFFIX=	2
 
 MAINTAINER=	qjail@a1poweruser.com
 COMMENT=	Utility to quickly deploy and manage jails
 
-USE_BZIP2=	yes
+USES=		tar:bzip2
+NEED_ROOT=	yes
 NO_BUILD=	yes
-PKGNAMESUFFIX=	2
-
-MAN8=		qjail.8 qjail-intro.8 qjail.conf.8 qjail-howto.8
 
 CONFLICTS_INSTALL=	qjail-1.* qjail-3.*
 
-NO_STAGE=	yes
-post-patch:
-	@${FIND} ${WRKSRC} -type f | ${XARGS} ${REINPLACE_CMD} \
-		-e 's|/usr/local|${PREFIX}|'
-	@${FIND} ${WRKSRC}/examples -name '*.bak' -delete
-
 do-install:
-	@${INSTALL_SCRIPT} ${WRKSRC}/qjail ${PREFIX}/bin
-	@${INSTALL_SCRIPT} ${WRKSRC}/qjail2 ${PREFIX}/etc/rc.d
-	@${INSTALL_SCRIPT} ${WRKSRC}/qjail-jail2 ${PREFIX}/etc/rc.d
-	@${INSTALL_DATA}   ${WRKSRC}/qjail.conf.sample ${PREFIX}/etc
-	@${INSTALL_DATA}   ${WRKSRC}/qjail.portsnap.conf ${PREFIX}/etc
+
+	${INSTALL_SCRIPT} ${WRKSRC}/qjail		\
+		${STAGEDIR}${PREFIX}/bin
+
+.for i in qjail2 qjail-jail2
+	${INSTALL_SCRIPT} ${WRKSRC}/${i}		\
+		${STAGEDIR}${PREFIX}/etc/rc.d
+.endfor
+
+.for i in qjail.conf.sample qjail.portsnap.conf
+	${INSTALL_DATA}   ${WRKSRC}/${i}		\
+		${STAGEDIR}${PREFIX}/etc
+.endfor
+
 .for i in qjail qjail-intro qjail.conf qjail-howto
-	@${INSTALL_MAN}    ${WRKSRC}/${i}.8 ${MAN8PREFIX}/man/man8
+	${INSTALL_MAN}    ${WRKSRC}/${i}.8		\
+		${STAGEDIR}${MAN8PREFIX}/man/man8
 .endfor
+
 # note examples are mandatory. qjail will not function without them
-	@${MKDIR} ${EXAMPLESDIR}
-	@(cd ${WRKSRC}/examples/ \
-	    && ${COPYTREE_SHARE} \* ${EXAMPLESDIR})
-
-post-install:
-	@${ECHO_MSG} "#"
-	@${CAT} ${PKGMESSAGE}
-	@${ECHO_MSG} "#"
+	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
+	@(cd ${WRKSRC}/examples/			\
+	&& ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR})
 
 .include <bsd.port.mk>

Modified: head/sysutils/qjail2/pkg-plist
==============================================================================
--- head/sysutils/qjail2/pkg-plist	Sun May 25 10:13:09 2014	(r355155)
+++ head/sysutils/qjail2/pkg-plist	Sun May 25 10:13:38 2014	(r355156)
@@ -3,6 +3,10 @@ etc/qjail.conf.sample
 etc/qjail.portsnap.conf
 etc/rc.d/qjail-jail2
 etc/rc.d/qjail2
+man/man8/qjail.8.gz
+man/man8/qjail-intro.8.gz
+man/man8/qjail-howto.8.gz
+man/man8/qjail.conf.8.gz
 %%EXAMPLESDIR%%/default/etc/make.conf
 %%EXAMPLESDIR%%/default/etc/motd
 %%EXAMPLESDIR%%/default/etc/periodic.conf
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2014-05-25 11:13:46 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!