Adds staging support, added shebangfixes, and USES tar:bzip2 to www/squid33. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->tmseck Over to maintainer (via the GNATS Auto Assign Tool)
*** Bug 191680 has been marked as a duplicate of this bug. ***
maintainer reset, moving this to patch-ready (untested, take at your own risk)
Hmmm... maybe Joe could give an evaluation of whether he thinks the fix in the duplicate https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191680 is better than this, so as to decide which one should be used in the end. -- Martin
i was hoping somebody else would grab these. :(
(In reply to Martin Birgmeier from comment #4) > Hmmm... maybe Joe could give an evaluation of whether he thinks the fix in > the duplicate https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191680 is > better than this, so as to decide which one should be used in the end. As tempting as a dynamic plist is, especially after going through a very obnoxious squid32 conversion with the same plist issues, I think we need to keep a "static" plist.
A commit references this bug: Author: marino Date: Sun Aug 17 12:47:42 UTC 2014 New revision: 365181 URL: http://svnweb.freebsd.org/changeset/ports/365181 Log: Stage www/squid33 This port needed a *lot* of love, and it needs a lot more. It has a ton of options (Do we need so many options rather than enabled by default?) and I suspect many options aren't staged properly. Also the way the plist is put together is crazy. This needs a proper static pkg-plist with PLIST_SUB switches. This port badly needs a full-time maintainer. (www/squid32 and www/squid are just as bad) I also added patch from PR 192119 while I was here. PR: 189903 Submitted by: joe (thralling.com) Lotsa TLC: marino Changes: head/www/squid33/Makefile head/www/squid33/files/patch-compat_compat.h
These squid port makefile are terrible, especially where plist is involved. There are likely LOTS of problems with the options. It's stage-safe with default options though. squid33 needs a full-time maintainer that knows what he/she is doing.