Bug 189937 - [stage] Add staging support to www/pound
Summary: [stage] Add staging support to www/pound
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 06:00 UTC by joe
Modified: 2014-09-06 05:16 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.15 KB, patch)
2014-05-19 06:00 UTC, joe
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-05-19 06:00:01 UTC
Adds staging support to www/pound.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-19 06:00:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->anders

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-11 13:28:52 UTC
maintainer was reset in July.
Move to patch-ready although there are no test logs (only two weeks left to stage this to save it)
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-13 23:08:10 UTC
this is not legal:

+post-build:
+	${RM} /root/.rnd


That means it touched the /root filesystem which is not allowed.  Poudriere would have flagged this in a big way.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-13 23:14:05 UTC
except pound doesn't install /root/.rnd so not sure what that line is all about.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-13 23:15:41 UTC
====> Running Q/A tests (stage-qa)
Warning: 'sbin/pound' is not stripped consider using ${STRIP_CMD}
Warning: 'sbin/poundctl' is not stripped consider using ${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done



The easiest fix is just to override the do-install target since there are so few files to install.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-13 23:24:27 UTC
A commit references this bug:

Author: marino
Date: Wed Aug 13 23:24:03 UTC 2014
New revision: 364820
URL: http://svnweb.freebsd.org/changeset/ports/364820

Log:
  Stage www/pound

  PR:		189937
  Submitted by:	Joe (thralling.com)
  Approved by:	Nobody, the maintainer was reset
  Lil' TLC:	marino

Changes:
  head/www/pound/Makefile
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-13 23:26:52 UTC
Besides the post-build target, the only other real mistake was leaving MAN8 defined.  I modernized it more with USES=tar and new options-depends, plus the new do-install target (which took over the post-install target)

closing PR now.