Bug 190041 - [patch] Add staging support and update to www/dwoo
Summary: [patch] Add staging support and update to www/dwoo
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 00:50 UTC by joe
Modified: 2014-09-06 05:16 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (34.86 KB, patch)
2014-05-21 00:50 UTC, joe
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-05-21 00:50:00 UTC
Adds staging support and update to www/dwoo.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-21 00:50:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-21 00:50:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-21 00:50:07 UTC
Maintainer of www/dwoo,

Please note that PR ports/190041 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/190041

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 joehorn 2014-05-22 20:31:17 UTC
Please commit it, thanks.


2014-05-21 7:50 GMT+08:00 Edwin Groothuis <edwin@freebsd.org>:

> Maintainer of www/dwoo,
>
> Please note that PR ports/190041 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/190041
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2014-06-06 05:33:09 UTC
Hi,

Why is %%DATADIR%% gone?

Please restore it.
Comment 6 joe 2014-06-26 18:53:34 UTC
The plist was rewritten.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-07-27 13:13:42 UTC
I'll overtake this.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-07-27 16:41:30 UTC
the DOCS handling has a serious bug.

The docs file and the main file are the same file -- downloaded twice (look at the distinfo hashes).  It extracts over itself.  There are no docs at all right now.

There were a few other issues but I've worked through those.  I'm not sure yet what to do about docs other than remove the option completely.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-07-27 16:46:46 UTC
Why has the master site switched to some random github repository that had the last commit 2 months ago?  Is that really the master site?
Comment 10 John Marino freebsd_committer freebsd_triage 2014-07-28 11:57:41 UTC
moving back to "discussion", this patch is nowhere near ready.
Comment 11 John Marino freebsd_committer freebsd_triage 2014-07-30 17:55:16 UTC
Joe, are you around?
Comment 12 John Marino freebsd_committer freebsd_triage 2014-08-10 08:18:22 UTC
As neither the maintainer (Joe Horn) nor the patch submitter (Joe Bender) is response, I'm going to reset the port.  This port was spared resetting due to this PR but the PR is unusable as it is.

I'll do this in a few hours.
Comment 13 John Marino freebsd_committer freebsd_triage 2014-08-10 08:18:48 UTC
s/response/responsive/
Comment 14 commit-hook freebsd_committer freebsd_triage 2014-08-10 13:55:50 UTC
A commit references this bug:

Author: marino
Date: Sun Aug 10 13:55:47 UTC 2014
New revision: 364543
URL: http://svnweb.freebsd.org/changeset/ports/364543

Log:
  Reset maintainership on www/dwoo

  This port was not staged, but it was spared a reset because somebody (not
  the maintainer) submitted a PR to stage it.  Unfortunately the PR has
  numerous problems which have not been addressed in the last couple of
  weeks.  Reset the maintainer now, and let the port be pruned at the end
  of the month if no one steps up to save it.

  PR:		190041
  Submitted by:	Joe (thralling.com)
  Approved by:	maintainer (Joe Horn)
  Rejected by:	marino (technical reasons)
  Approved by:	portmgr (implicit, NOT_STAGED)

Changes:
  head/www/dwoo/Makefile
Comment 15 John Marino freebsd_committer freebsd_triage 2014-08-10 14:01:01 UTC
closing due to lack of response.