Bug 190121 - new port databases/sqlite-ext-pcre
Summary: new port databases/sqlite-ext-pcre
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 20:30 UTC by Vick Khera
Modified: 2014-08-24 20:01 UTC (History)
3 users (show)

See Also:


Attachments
file.shar (4.12 KB, text/plain)
2014-05-22 20:30 UTC, Vick Khera
no flags Details
update shar file for port (2.79 KB, application/x-shar)
2014-08-07 16:34 UTC, Vick Khera
no flags Details
output from poudriere testport (16.22 KB, text/plain)
2014-08-07 16:35 UTC, Vick Khera
no flags Details
new shar, without portlint/build issues (2.77 KB, text/plain)
2014-08-09 09:27 UTC, Kurt Jaeger
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vick Khera 2014-05-22 20:30:00 UTC
	
New port to install an SQLite extension that provides a regexp() function
based on the PCRE library.

This is installed from the github repo. As there are no tags, I set the
version to be the date of the most recent commit. I do not know if this
is the best way to number it.

I based this on the sqlite-ext-miscfuncs port.

How-To-Repeat: 	
n/a
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-07 15:17:55 UTC
Hi, if you are still interested in having this port in FreeBSD, it may (or may not) need to be reworked to support stage, and it may need updating to other newer conventions such as "USES" which is expanding all time.
For staging, see http://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-May/000080.html


Additionally, you need to provide some sort of quality assurance.    
In order of preference, we are looking for:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) at least this: https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html

Please provide an updated shar file and attach a test log.  Alternatively, please indicate if you are no longer interested in having this software in the Ports Collection and that we can close the PR.

Thanks!
Comment 2 Vick Khera 2014-08-07 16:34:52 UTC
Created attachment 145454 [details]
update shar file for port

I attach an updated shar file. The only change is that is uses pkgconfig.
Comment 3 Vick Khera 2014-08-07 16:35:54 UTC
Created attachment 145455 [details]
output from poudriere testport
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-07 16:50:16 UTC
Great, thanks!  Moving this to "patch-ready" status.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-09 09:26:39 UTC
I tested the patch and had this issue:

----------------
make check-plist
[...]
===>  Building for sqlite-ext-pcre-20100208
gmake[1]: Entering directory `/usr/local/home/pi/myp/databases/sqlite-ext-pcre/work/ralight-sqlite3-pcre-c98da41'
cc -shared -o pcre.so -I/usr/local/include   -fPIC -W -Werror pcre.c -L/usr/local/lib -lpcre   -Wl,-z,defs
gmake[1]: Leaving directory `/usr/local/home/pi/myp/databases/sqlite-ext-pcre/work/ralight-sqlite3-pcre-c98da41'
===>  Staging for sqlite-ext-pcre-20100208
** Missing /usr/local/home/pi/myp/databases/sqlite-ext-pcre/files/README.in for sqlite-ext-pcre-20100208.
*** Error code 1

Stop.
make: stopped in /usr/local/home/pi/myp/databases/sqlite-ext-pcre

-----------------

and portlint -A says:

-----------------
FATAL: Makefile: [35]: contiguous blank lines (> 1 lines) found.
WARN: Makefile: [46]: NOPORTDOCS found.  Consider using PORT_OPTIONS:MDOCS.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: COMMENT should begin with a capital, and end without a period
WARN: Makefile: Consider defining LICENSE.
FATAL: files: empty directory should be removed.
2 fatal errors and 4 warnings found.

-----------------

I'll attach a modified shar, please check and approve, then it can be committed.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-09 09:27:38 UTC
Created attachment 145549 [details]
new shar, without portlint/build issues

See above
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-24 19:53:22 UTC
submitter doesn't need to approve fixes from committer.  Move this to back to patch-ready status based on Kurt's update.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-08-24 20:01:25 UTC
A commit references this bug:

Author: pi
Date: Sun Aug 24 20:00:58 UTC 2014
New revision: 366009
URL: http://svnweb.freebsd.org/changeset/ports/366009

Log:
  New port: databases/sqlite-ext-pcre

  This is sqlite3-pcre, an extension for sqlite3 that uses libpcre to
  provide a regexp() function to use with the REGEXP operator.

  PR:		190121
  Submitted by:	Vick Khera <vivek@khera.org>

Changes:
  head/databases/Makefile
  head/databases/sqlite-ext-pcre/
  head/databases/sqlite-ext-pcre/Makefile
  head/databases/sqlite-ext-pcre/distinfo
  head/databases/sqlite-ext-pcre/pkg-descr
  head/databases/sqlite-ext-pcre/pkg-message
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-24 20:01:51 UTC
Committed, thanks!