Bug 190718 - Error during installing net-mgmt/collectd5 on amd64 FreeBSD8.4 via port
Summary: Error during installing net-mgmt/collectd5 on amd64 FreeBSD8.4 via port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-06 15:54 UTC by df
Modified: 2014-07-05 16:12 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description df 2014-06-06 15:54:32 UTC 
Dear sir.
I have this problem then I try to install /usr/ports/net-mgmt/collectd5 on my FreeBSD 8.4 using standard command "make install clean" if I set configuration option "STATGRAB - Enable statgrab-based plugins (disk, interface, etc)". Without this option the installation was seccessfully without any error.
Collectd version 4 was seccessfully installed on my system but version 5 was unseccesfully installed. I have update all popts using portupgrade before. If I try to install collectd5 on other clean FreeBSD 8.4 system under VirtualBox then I have same error.
 This is output of the process writing using 'script' command:
===============================================
Script started on Fri Jun  6 19:31:56 2014

root@bsd84:/usr/ports/net-mgmt/collectd5 # make

===>  Building for collectd5-5.4.1_2
Making all in libltdl
gmake[1]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
gmake  all-am
gmake[2]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
gmake[2]: Nothing to be done for `all-am'.
gmake[2]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
gmake[1]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
Making all in src
gmake[1]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake  all-recursive
gmake[2]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
Making all in libcollectdclient
gmake[3]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
gmake  all-am
gmake[4]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
gmake[4]: Nothing to be done for `all-am'.
gmake[4]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
gmake[3]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
Making all in liboconfig
gmake[3]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake  all-am
gmake[4]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake[4]: Nothing to be done for `all-am'.
gmake[4]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake[3]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake[3]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
  CC       users_la-users.lo
users.c: In function 'users_read':
users.c:105: error: too few arguments to function 'sg_get_user_stats'
users.c:109: error: 'sg_user_stats' has no member named 'num_entries'
gmake[3]: *** [users_la-users.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake: *** [all-recursive] Error 1
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop in /usr/ports/net-mgmt/collectd5.
*** Error code 1

Stop in /usr/ports/net-mgmt/collectd5.
root@bsd84:/usr/ports/net-mgmt/collectd5 # cat > Makefile.local

MAKE_JOBS_UNSAFE=yes
root@bsd84:/usr/ports/net-mgmt/collectd5 # cat > Makefile.local

===>  Building for collectd5-5.4.1_2
Making all in libltdl
gmake[1]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
gmake  all-am
gmake[2]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
gmake[2]: Nothing to be done for `all-am'.
gmake[2]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
gmake[1]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/libltdl'
Making all in src
gmake[1]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake  all-recursive
gmake[2]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
Making all in libcollectdclient
gmake[3]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
gmake  all-am
gmake[4]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
gmake[4]: Nothing to be done for `all-am'.
gmake[4]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
gmake[3]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/libcollectdclient'
Making all in liboconfig
gmake[3]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake  all-am
gmake[4]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake[4]: Nothing to be done for `all-am'.
gmake[4]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake[3]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src/liboconfig'
gmake[3]: Entering directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
  CC       users_la-users.lo
users.c: In function 'users_read':
users.c:105: error: too few arguments to function 'sg_get_user_stats'
users.c:109: error: 'sg_user_stats' has no member named 'num_entries'
gmake[3]: *** [users_la-users.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/net-mgmt/collectd5/work/collectd-5.4.1/src'
gmake: *** [all-recursive] Error 1
*** Error code 1

Stop in /usr/ports/net-mgmt/collectd5.
*** Error code 1

Stop in /usr/ports/net-mgmt/collectd5.
*** Error code 1

Stop in /usr/ports/net-mgmt/collectd5.
root@bsd84:/usr/ports/net-mgmt/collectd5 # ^D..exit

Script done on Fri Jun  6 19:32:45 2014
========================================

Environment:
1) FreeBSD bsd84 8.4-RELEASE FreeBSD 8.4-RELEASE #0 r251259: Sun Jun  2 21:26:57 UTC 2013     root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

2) FreeBSD mail.bloknot.pp.ua 8.4-RELEASE-p4 FreeBSD 8.4-RELEASE-p4 #0 r255451: Wed Sep 11 07:54:19 EEST 2013     root@mail.crimean.pp.ua:/usr/obj/usr/src/sys/NEW_21_05_13  amd64

How-To-Repeat:
To repeat the problem enough try to install collectd5 with option "STATGRAB - Enable statgrab-based plugins (disk, interface, etc)" on clean FreeBSD 8.4.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2014-06-08 20:27:43 UTC 
This is a ports bug
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2014-06-09 06:56:13 UTC 
Fix synopsis, add maintainer to cc:.
Comment 3 Kevin Bowling freebsd_committer freebsd_triage 2014-06-11 07:19:26 UTC 
This only affects FreeBSD < 9, newer versions use the getutxent(3) codepath.

I've created a patch here:  https://github.com/llnw/collectd-build-freebsd/commit/34602378a9f6bd73f58da76ce362abdbbf2f49f8
Comment 4 Krzysztof 2014-06-11 08:55:34 UTC 
Ok, I approve this patch. Looks great :-)
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2014-07-05 16:11:44 UTC 
Committed, thanks.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-07-05 16:12:17 UTC 
A commit references this bug:

Author: adamw
Date: Sat Jul  5 16:11:39 UTC 2014
New revision: 360770
URL: http://svnweb.freebsd.org/changeset/ports/360770

Log:
  Fix build for FreeBSD < 9 where libstatgrab 0.90 codepath is used.

  PR:		190718
  Submitted by:	Kevin Bowling [patch]
  Approved by:	maintainer

Changes:
  head/net-mgmt/collectd5/files/patch-src__users.c