While marking attachments as diffs works well, it seems that the Diff viewer is confused by svn diffs and doesn't show newly added files. See bug 190505 for an example.
Actually, bug 190198 has an SVN diff with new files.
I also may add, that in Diff view parts of patches for "patches" (which is usually located in files/ directory of the port) doesn't get shown. Bug 191111 is an example - if you download it - you will see that this patch touches files/patch-Makefile.in, but in html Diff view this part is not presented.
Similar case with attachment #143950 [details] of bug #191101.
Likewise attachment #144177 [details], attachment #144432 [details], and attachment #144950 [details] of bug #191426. It eats the patch in both side-by-side and raw diff mode. The latter is particularly odd... how is it eating parts of patches that it's displaying raw? The patch remains intact, when you access it with the attachment link itself (rather than the diff link alongside it). Given that our bugzilla is known not to work with the "diff" link, is it worth disabling it until bugmeister can repair the problem?
And another case: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=144956 when viewed as diff in bugzilla: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=144956&action=diff
Occurs also with attachment on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192259
Aaaand another one: Bug 193271 Attachment 147188 [details]. The new file in this patch (files/patch-xboard.conf.in) is shown in the raw version of the attachment when clicking on the description¹⁾ as well as when clicking on “Details”²⁾ right to it. But it is not showing up when clicking on “Diff”³⁾. That is annoying! Pray do correct this! Thank you in advance, Kalten ¹⁾ https://bz-attachments.freebsd.org/attachment.cgi?id=147188 ²⁾ https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147188&action=edit ³⁾ https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147188&action=diff
The problem is caused by devel/p5-PatchReader, which has several matcher issues in its parser. A fix is filed in bug 193785 and currently waits for approval by the maintainer.
Added reports from other systems for this issue.
A commit references this bug: Author: mva Date: Sun Sep 21 16:59:00 UTC 2014 New revision: 368776 URL: http://svnweb.freebsd.org/changeset/ports/368776 Log: - Fix diff scan and output for new files within a non-CVS diff - Fix file name mangling for new files with whitespace - Convert line endings to unix This also should fix an issue in Bugzilla for patch attachments being truncated, if they contain new files. Some changes from https://rt.cpan.org/Public/Bug/Display.html?id=94181 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=399391 were incorporated in this patch. PR: 193785, 190724 Approved by: toni.viemero@iki.fi (maintainer) Changes: head/devel/p5-PatchReader/Makefile head/devel/p5-PatchReader/files/ head/devel/p5-PatchReader/files/patch-lib__PatchReader__Raw.pm
The fix from bug 193785 has been committed. I'm looking for a time frame to incoprorate the fix within the Bugzilla environment, so getting this fixed might take another few days.
A commit references this bug: Author: ohauer Date: Sun Sep 21 21:47:02 UTC 2014 New revision: 368791 URL: http://svnweb.freebsd.org/changeset/ports/368791 Log: - unbreak patch stage (patch does not apply because line out of range) PR: 193785, 190724 Approved by: implicit Changes: head/devel/p5-PatchReader/files/patch-lib__PatchReader__Raw.pm
devel/p5-PatchReader was updated on the machine running Bugzilla. New files within patch attachments should be displayed correctly now. Please reopen this issue, if you still notice a a misbehaviour