Bug 190841 - security/p5-PGP: unbreak on amd64, change build-dep to security/pgpin
Summary: security/p5-PGP: unbreak on amd64, change build-dep to security/pgpin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 19:59 UTC by Kurt Jaeger
Modified: 2014-06-11 20:59 UTC (History)
2 users (show)

See Also:

Attachments
Patch (585 bytes, patch)
2014-06-09 19:59 UTC, Kurt Jaeger 		no flags Details | Diff
patch to really move it to pgpin (1.61 KB, text/plain)
2014-06-10 18:03 UTC, Kurt Jaeger 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2014-06-09 19:59:24 UTC 
Created attachment 143577 [details]
Patch

Unbreak on amd64 by changing the build-dependency from security/pgp to security/pgpin.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-06-09 20:01:53 UTC 
pending maintainer-approval
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-06-09 20:29:55 UTC 
Approved.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2014-06-09 20:44:36 UTC 
Fixed with commit r357204.
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2014-06-10 17:45:45 UTC 
Please review the patch.
BUILD_DEPENDS=  pgp:${PORTSDIR}/security/pgpin

The port security/pgpin installs als ${PREFIX}/bin/pgpin,
not as ${PREFIX}/bin/pgp.
the dependency will not work.

BUILD_DEPENDS=  pgpin:${PORTSDIR}/security/pgpin

but the perl script may not work if it calls only "pgp"
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2014-06-10 18:03:49 UTC 
Created attachment 143627 [details]
patch to really move it to pgpin

Thanks for the bug report from Dirk!
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2014-06-10 18:04:41 UTC 
Please approve.
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-06-11 20:47:56 UTC 
Approved ..
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2014-06-11 20:58:58 UTC 
Fix committed in r357537.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-06-11 20:59:06 UTC 
A commit references this bug:

Author: pi
Date: Wed Jun 11 20:58:13 UTC 2014
New revision: 357537
URL: http://svnweb.freebsd.org/changeset/ports/357537

Log:
  security/p5-PGP: fix run dependency on security/pgpin

  - fix path to pgpin binary

  PR:		ports/190841
  Approved by:	Muhammad Moinur Rahman <5u623l20@gmail.com> (maintainer)
  Approved by:	mentors (implicit)

Changes:
  head/security/p5-PGP/Makefile
  head/security/p5-PGP/files/
  head/security/p5-PGP/files/patch-Pipe.pm