Bug 190845 - [MAINTAINER] net/nph: Update Makefile to support STAGEDIR
Summary: [MAINTAINER] net/nph: Update Makefile to support STAGEDIR
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 20:29 UTC by Jim Pirzyk
Modified: 2014-06-11 14:54 UTC (History)
1 user (show)

See Also:

Attachments
Add STAGEDIR to Makefile (735 bytes, patch)
2014-06-09 20:29 UTC, Jim Pirzyk 		no flags Details | Diff
nph.patch (3.35 KB, text/plain)
2014-06-10 03:23 UTC, Danilo Egea Gondolfo 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Pirzyk freebsd_committer freebsd_triage 2014-06-09 20:29:14 UTC 
Created attachment 143580 [details]
Add STAGEDIR to Makefile

Patch to update ports/net/nph/Makefile to support staged port builds.
Comment 1 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 03:23:38 UTC 
Created attachment 143591 [details]
nph.patch
Comment 2 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 03:24:42 UTC 
I've made some improvements in your patch. Can you check if it's working fine?

Thanks!
Comment 3 Jim Pirzyk freebsd_committer freebsd_triage 2014-06-10 12:00:33 UTC 
(In reply to Danilo Egea Gondolfo from comment #2)
> I've made some improvements in your patch. Can you check if it's working
> fine?
> 
> Thanks!

It seems to work but I get this warning when packaging:

pkg-static: fopen(/usr/ports/Keywords/sample.yaml): No such file or directory
pkg-static: unknown keyword sample, ignoring @sample
Comment 4 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 13:44:44 UTC 
The system you used to test is with the ports updated? This file was added 2 months ago. http://svnweb.freebsd.org/ports?view=revision&revision=351064
Comment 5 Jim Pirzyk freebsd_committer freebsd_triage 2014-06-10 15:21:25 UTC 
(In reply to Danilo Egea Gondolfo from comment #4)
> The system you used to test is with the ports updated? This file was added 2
> months ago. http://svnweb.freebsd.org/ports?view=revision&revision=351064

Yes the machine was freshly installed less than 2 weeks ago.
Comment 6 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 16:07:41 UTC 
And how do you keep your ports updated? Via subversion?
Comment 7 Jim Pirzyk freebsd_committer freebsd_triage 2014-06-10 17:04:06 UTC 
portsnap
Comment 8 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 23:45:59 UTC 
I've extracted the ports with portsnap and the file sample.yaml just was there. Furthermore, the port had passed on the tests on redports https://redports.org/buildarchive/20140610032702-40387/

Can you update your ports and try again? Just to make sure...
Comment 9 Jim Pirzyk freebsd_committer freebsd_triage 2014-06-11 12:12:19 UTC 
Re-downloaded the ports tree and the error has gone away.
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-06-11 14:53:46 UTC 
A commit references this bug:

Author: danilo
Date: Wed Jun 11 14:53:07 UTC 2014
New revision: 357487
URL: http://svnweb.freebsd.org/changeset/ports/357487

Log:
  - Add stage support

  PR:		ports/190845
  Submitted by:	Jim Pirzyk <pirzyk@FreeBSD.org>

Changes:
  head/net/nph/Makefile
  head/net/nph/pkg-plist
Comment 11 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-11 14:54:48 UTC 
Committed with some changes. Thanks!