Bug 190852 - [MAINTAINER] emulators/zsnes: OPTIONS helpers, fix build with Clang
Summary: [MAINTAINER] emulators/zsnes: OPTIONS helpers, fix build with Clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-10 01:27 UTC by Naram Qashat
Modified: 2014-06-10 04:11 UTC (History)
1 user (show)

See Also:

Attachments
zsnes-1.51.patch (1.79 KB, patch)
2014-06-10 01:27 UTC, Naram Qashat 		no flags Details | Diff
Replacement patch (2.57 KB, patch)
2014-06-10 03:50 UTC, Naram Qashat 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2014-06-10 01:27:24 UTC 
Created attachment 143587 [details]
zsnes-1.51.patch

- Use OPTIONS helpers.
- Fix build with Clang.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 02:56:28 UTC 
It's failing with clang. [1]
Can you check, please?

Thanks!

[1] https://redports.org/buildarchive/20140610024301-7947/
Comment 2 Naram Qashat 2014-06-10 03:50:54 UTC 
Created attachment 143593 [details]
Replacement patch

I'm replacing the patch with another one. This one adds a files/patch-tools_depbuild.cpp. I'm currently making a 10/i386 jail with poudriere so I can see if any other issues come up, but this should at least let it progress a little farther. I'm hoping none of the other files need additional patching, though. If they do, let me know, I'll look into it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-06-10 04:10:36 UTC 
A commit references this bug:

Author: danilo
Date: Tue Jun 10 04:09:41 UTC 2014
New revision: 357255
URL: http://svnweb.freebsd.org/changeset/ports/357255

Log:
  - Fix build with clang
  - Use options helpers

  PR:		ports/190852
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com>

Changes:
  head/emulators/zsnes/Makefile
  head/emulators/zsnes/files/patch-tools_depbuild.cpp
Comment 4 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-06-10 04:11:39 UTC 
It works [1], committed! Thanks!

[1] https://redports.org/buildarchive/20140610040101-8264/