Bug 190953 - [patch] Added stage support to www/thundersnarf
Summary: [patch] Added stage support to www/thundersnarf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-12 02:09 UTC by joe
Modified: 2014-06-13 21:44 UTC (History)
2 users (show)

See Also:

Attachments
Added stage support to thundersnarf (202.98 KB, text/plain)
2014-06-12 02:09 UTC, joe 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-06-12 02:09:11 UTC 
Created attachment 143697 [details]
Added stage support to thundersnarf

Added stage support to www/thundersnarf.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-06-13 15:33:19 UTC 
CC: maintainer so he knows what's going on
Comment 2 John Marino freebsd_committer freebsd_triage 2014-06-13 16:41:23 UTC 
wow, looking at this patch it seems that the original pkg-plist was essentially completely and utterly broken.

Which means the PORTREVISION needs to be incremented too.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-13 20:34:56 UTC 
like thundercache, this port had some existing issues.
like passing -m 555 to INSTALL_SCRIPT which already sets mode, and muting installation commands.  Also cp -r used install of install macros, so I'm cleaning these up too.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-06-13 21:40:17 UTC 
A commit references this bug:

Author: marino
Date: Fri Jun 13 21:39:42 UTC 2014
New revision: 357723
URL: http://svnweb.freebsd.org/changeset/ports/357723

Log:
  www/thundersnarf: Add stage support and several fixes

  The PR that provided stage support corrected an almost empty pkg-plist
  so that it now has over 2400 entries.  However, that wasn't the only
  issue.  Some additional fixes "while we're here" are:

    * Convert to USES+=tar:bzip2 (PR)
    * Use new style for LIB_DEPENDS (PR)
    * Simplify WRKSRC (remove redundant :R modifier)
    * Convert to USES+=pgsql and WANT_PGSQL from USE_PGSQL
    * Convert to USE_PHP+= pdo pdo_pgsql
    * Remove manual RUN_DEPENDS
    * Remove redundant "-m 555" as INSTALL_SCRIPT already does this
    * Unmute installation commands
    * Use COPYTREE_SHARE instead of cp -R
    * Remove pkg-message post-install target (missed by PR)
    * Remove whitespace in WWW line of pkg-descr file
    * use @owner, @group in pkg-plist (functionality lost by PR)
    * Add port-extract to remove unwanted file that appears (F10+)

  PR:		190953
  Submitted by:	Joe Benden
  Fixes by:	marino
  Approved by:	stage and just-fix-it blankets

Changes:
  head/www/thundersnarf/Makefile
  head/www/thundersnarf/pkg-descr
  head/www/thundersnarf/pkg-plist
Comment 5 John Marino freebsd_committer freebsd_triage 2014-06-13 21:44:23 UTC 
Joe,
Note that all the new pkg-plist lines were wrong.
You had them start "%%WWWDIR%%/thundersnarf/" but WWWDIR = www/thundersnarf.
This made the line be "www/thundersnarf/thundersnarf".  Only one is needed, so I removed "/thundersnarf".

It passes redports 8x

Also not that the tarball extracts differently between FreeBSD 8/9 and FreeBSD 10/11.  An extra file appears in FreeBSD 8/9.  I had to use a post-extract target to remove it *if* it's there.

Lots of additional changes and the remove of the cat pkg-message was missed (it's not needed by stage).