Bug 190960 - [Maintainer: staging] security/p5-openxpki-deployment
Summary: [Maintainer: staging] security/p5-openxpki-deployment
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-12 09:44 UTC by Sergei Vyshenski
Modified: 2014-06-13 15:31 UTC (History)
2 users (show)

See Also:


Attachments
patch for staging support (3.65 KB, patch)
2014-06-12 09:44 UTC, Sergei Vyshenski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2014-06-12 09:44:42 UTC
Created attachment 143703 [details]
patch for staging support

This port has two long-standing and non-related problems: 
	1) not staged,
	2) does not compile on FreeBSD-10+ (this is controled by the IGNORE
		constuct in port security/p5-openxpki, from which we depend).

	This patch deals with the first promlem only, the second problem will 
	be solved in the next version of the openxpki port suite. 

	This patch:

	- adds staging support to Makefile
	- increments PORTREVISION
	- adds LICENSE
	- fixes pkg-plist to include man pages
	- fixes rc.d script to new rules

	Please note that the line in the Makefile 

	CONFIGURE_ARGS= --prefix ${PREFIX}

	should be left intact, that is without incerting STAGEDIR, because here
	we do not specify "destination" of the port, but rather a special
	configuration option of the original software.

	This patch has passed tests on FreeBSD-9.3-beta2 (i386) as follows:

1) with rclint,
2) with ports-mgmt/porttools running "port test security/p5-openxpki-deployment",
3) building, installing and deinstalling a package as a non-root user.
Comment 1 Sergei Vyshenski 2014-06-13 08:05:28 UTC
This patch has also successfully passed test with "poudriere testport" on FreeBSD-9.3-beta2 (i386).
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-06-13 15:27:54 UTC
A commit references this bug:

Author: marino
Date: Fri Jun 13 15:27:15 UTC 2014
New revision: 357691
URL: http://svnweb.freebsd.org/changeset/ports/357691

Log:
  security/p5-openxpki-deployment: Unbreak by adding Stage support

  In addition to changes related to staging:
    * Adds LICENSE (ART20)
    * Fixes rc.d script for new rules
    * remove BROKEN definition (added due to lack of staging)

  What the patch does not do is fix the build on FreeBSD 10+  This will
  be dealt with in a following patch.  Testing without poudriere and
  redports (F8 and F9, x4).

  PR:		190960
  Submitted by:	maintainer (Sergei Vyshenski)

Changes:
  head/security/p5-openxpki-deployment/Makefile
  head/security/p5-openxpki-deployment/files/openxpki.in
  head/security/p5-openxpki-deployment/pkg-plist
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-13 15:31:00 UTC
Patch was great, thanks!