=======================<phase: deinstall >============================ ====>> Checking for orphaned files and directories in stage directory (missing ====>> Files or directories orphaned: /var/run/hald/hald-local /var/run/hald/hald-runner ===> Cleaning for hal-0.5.14_26 build of /usr/ports/sysutils/hal ended at Fri Jun 20 21:58:03 CEST 2014 build time: 00:00:22
Assign to maintainer and CC kwm whom I believe did the actual staging. Found on poudriere bulk -t (FreeBSD 10/amd64)
Here is the latest result (FreeBSD 10/AMD64/Poudriere 3.0.16) =========================================================================== ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: @unexec rmdir "/var/run/hald/hald-local" >/dev/null 2>&1 || : Error: Orphaned: @unexec rmdir "/var/run/hald/hald-runner" >/dev/null 2>&1 || : ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies Warning: Possibly owned by dependency: @dirrmtry share/PolicyKit/policy Warning: Possibly owned by dependency: @dirrmtry share/PolicyKit Warning: Possibly owned by dependency: @unexec rmdir "/var/lib" >/dev/null 2>&1 || : ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 I think the hald-local, hald-runner errors are false. This is from the pkg-plist: @unexec rm -f /var/run/hald/hald.pid 2>/dev/null || true @unexec rm -rf /var/run/hald/hald-local 2>/dev/null || true @unexec rm -rf /var/run/hald/hald-runner 2>/dev/null || true @unexec rmdir /var/run/hald 2>/dev/null || true @unexec rmdir /var/cache/hald 2>/dev/null || true @unexec rmdir /var/lib/hal 2>/dev/null || true @unexec rmdir /var/lib 2>/dev/null || true when I run "make makeplist", I get something like: @unexec rmdir /var/run/hald/hald-local 2>/dev/null || true @unexec rmdir /var/run/hald/hald-runner 2>/dev/null || true @unexec rmdir /var/run/hald 2>/dev/null || true @unexec rmdir /var/cache/hald 2>/dev/null || true @unexec rmdir /var/lib/hal 2>/dev/null || true @unexec rmdir /var/lib 2>/dev/null || true I think hal pkg-plist is technically correct, but the plist check is bad. I can think of some hacks to fool the check, but I am philosophically against that. What's the best way to address this? And what about the "possibly owned" errors?
Hal is used in a lot of ports, and this keeps breaking my "poudriere bulk -t" runs, so I'm going to change "unexec rm -rf" to "unexec rmdir" to workaround check-plist inadequacies. Unless somebody says something very soon. This PR timed out LONG ago.
A commit references this bug: Author: marino Date: Wed Aug 13 19:10:46 UTC 2014 New revision: 364801 URL: http://svnweb.freebsd.org/changeset/ports/364801 Log: sysutils/hal: Adjust pkg-plist so it passes stage-qa and leftover checks Hal was not passing poudriere testport or poudriere bulk -t runs due to failing the stage-qa tests and later a leftover check with /var/lib/PolicyKit/user-haldaemon.auths. The reported error is actually not wrong, but rather an inadequacy in the check-plist logic. However, hald is a dependency for a lot of ports and it keeps breaking bulk -t runs, so I switched "@unexec rm -rf" to "@unexec rmdir" to that it would build cleanly in poudriere (gnome@ had fair warning!). If the check-plist logic is improved in the future, this can be changed back to the better "rm -rf" command then. While here, stop trying to remove directories that PolicyKit installed because this will always fail. This clears up stage-qa warnings. PR: 191223 Submitted by: marino Approved by: maintainer timeout (2 months, 2 pings) Changes: head/sysutils/hal/Makefile head/sysutils/hal/pkg-plist
I hope this fix is satisfactory to all.