Created attachment 144132 [details] file.shar VictorOps is an on-call management and incident notification service. This is the Nagios/Icinga integration package for VictorOps. WWW: http://www.victorops.com The port also includes a patch to fall back to qpage if an alert fails to be delivered to the VictorOps service. A nice feature if the alert is about your Internet service falling down. How-To-Repeat: Be a VictorOps customer using Nagios or Icinga and find yourself a bit frustrated with the Linuxisms in the shell scripts.
Can you provide test logs from poudriere or redports or at least the output from "make check-plist" followed by "make stage-qa" ?
Created attachment 145188 [details] Poudriere log The requested Poudriere log
(In reply to John Marino from comment #1) > Can you provide test logs from poudriere or redports or at least the output > from "make check-plist" followed by "make stage-qa" ? Just attached it to the ticket, I hope this is what you were looking for.
It was, but unfortunately I was too vague. You should use either "poudriere testport" or "poudriere bulk -t" so it does the QA tests. Now I have to go back to a bunch of PRs and clarify that since I cut and pasted the same request. Anyway, your log doesn't do the extra stage-qa tests which is what we are looking for.
Created attachment 145452 [details] Results of poudriere testport Attached is the results of poudriere's testport. The first run did find 2 check-plist errors, that I'm not sure are valid, but I added to pkg-plist anyway to clear the errors: Error: Orphaned: @dirrmtry etc/periodic/daily Error: Orphaned: @dirrmtry etc/periodic I'll update the shar file attachement in a minute.
Created attachment 145453 [details] Updtaed SHAR with pkg-plist fixed and pkg-message added. An updated shar file for victorops-nagios. It has 2 changes: Added two lines to pkg-plist: @dirrmtry etc/periodic/daily @dirrmtry etc/periodic to silence errors from pkg-plist. I also added pkg-message to indicate that ca_root_nss requires the ETCSYMLINK option in order for wget to be able to check VictorOps' GoDaddy certificate. I'm unsure if I should add RUN_DEPENDS+= /etc/ssl/cert.pem:${PORTSDIR}/security/ca_root_nss as if it is built with out the option then the build will fail since the package is already installed. It seems like an inelegant solution. I have left this out not liking the approach.
Thanks, it looks patch-ready now.
A commit references this bug: Author: pi Date: Sat Aug 9 09:49:52 UTC 2014 New revision: 364420 URL: http://svnweb.freebsd.org/changeset/ports/364420 Log: New port: net-mgmt/victorops-nagios VictorOps is an on-call management and incident notification service. This is the Nagios/Icinga integration package for VictorOps. WWW: http://www.victorops.com PR: 191383 Submitted by: rand@iteris.com Changes: head/net-mgmt/Makefile head/net-mgmt/victorops-nagios/ head/net-mgmt/victorops-nagios/Makefile head/net-mgmt/victorops-nagios/distinfo head/net-mgmt/victorops-nagios/files/ head/net-mgmt/victorops-nagios/files/patch-check_victorops_cmds head/net-mgmt/victorops-nagios/files/patch-check_victorops_forwarder head/net-mgmt/victorops-nagios/files/patch-do_victorops_heartbeat head/net-mgmt/victorops-nagios/files/patch-enqueue_alert head/net-mgmt/victorops-nagios/files/patch-forward_alerts head/net-mgmt/victorops-nagios/files/patch-support_collect.sh head/net-mgmt/victorops-nagios/files/patch-utils head/net-mgmt/victorops-nagios/files/patch-victorops.cron head/net-mgmt/victorops-nagios/files/qpage-patch head/net-mgmt/victorops-nagios/pkg-descr head/net-mgmt/victorops-nagios/pkg-message head/net-mgmt/victorops-nagios/pkg-plist
Committed, thanks.