Bug 191434 - [maintainer update] sysutils/respond: Update to 1.3, Use Github
Summary: [maintainer update] sysutils/respond: Update to 1.3, Use Github
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-27 13:01 UTC by j.witteveen
Modified: 2014-07-07 04:47 UTC (History)
1 user (show)

See Also:


Attachments
Update to 1.3 and move to GitHub (1.84 KB, patch)
2014-07-05 12:43 UTC, j.witteveen
no flags Details | Diff
Update to 1.3 and move to GitHub (using macros) (1.93 KB, patch)
2014-07-05 14:51 UTC, j.witteveen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description j.witteveen 2014-06-27 13:01:00 UTC
The sysutils/respond port suffers severe bitrot. It did not keep up with changes to SourceForge (its homepage was automatically removed) or the port build system.

As it does not look like anyone ever used it (besides me: the author and maintainer), I do not consider it worthwhile to refresh the port and implement the necessary staging updates. The source code of respond remains available at https://github.com/joukewitteveen/respond.

Fix:
removal of the port altogether
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-02 00:41:24 UTC
Jouke, the port has now been staged as of r359583 [1], with a patch added to the source Makefile, which adds DESTDIR support:

http://svnweb.freebsd.org/ports?view=revision&revision=359583

I would be happy to work with you to update your port to use the github sources (if no longer available on sourceforge). All we'll need is a tag for the 2.1 release.

Would you like to update this removal request to go for that instead?
Comment 2 j.witteveen 2014-07-03 22:46:12 UTC
Sounds great! Unbelievable that all these nasty errors are gone with so little modifications to the port Makefile. I will get to tagging a release shortly.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-07-04 01:39:50 UTC
Update summary with latest information.
Comment 4 j.witteveen 2014-07-05 12:43:03 UTC
Created attachment 144422 [details]
Update to 1.3 and move to GitHub
Comment 5 j.witteveen 2014-07-05 12:44:41 UTC
The GH macros dazzled me. I hope this is correct.

Please review and apply.

Thanks a lot for your help Kubilay Kocak!
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-05 12:58:26 UTC
You're welcome :)

For the Github bits, have a look the GH_* variables in /usr/ports/Mk/bsd.sites.mk

With those bits, you dont need MASTER_SITES, DISTNAME, DISTFILES or WRKSRC overrides.

If you get stuck, just let me know and I can take it from here.

Rest of the patch looks good, does it pass portlint and port test? (from ports-mgmt/porttools)
Comment 7 j.witteveen 2014-07-05 14:51:48 UTC
Created attachment 144424 [details]
Update to 1.3 and move to GitHub (using macros)

This one uses the GH_ macros, which mandate specification of a commit hash.
Comment 8 j.witteveen 2014-07-05 14:54:52 UTC
The previous MASTER_SITES= value was taken from /usr/ports/Mk/bsd.sites.mk ("GitHub [...] without the need for any of the above").

I don't understand why the macros necessitate the specification of a hash.

The revised version passes all tests.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-05 14:56:15 UTC
The hash is used to derive a value WRKSRC, as the tarball contains a directory containing the hash string :)
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-05 14:57:14 UTC
Latest patch looks good, I'll test & commit this tomorrow morning. Great work
Comment 11 j.witteveen 2014-07-05 15:01:27 UTC
The 'ordinary' release tarball from GitHub (which the previous patch used) does not include the hash. I don't understand the logic behind the codeload.github/cloud.github downloads and the inclusion of the hash. If you do and it is simple to explain, please do. In any case, thanks for your guidance!
Comment 12 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-05 15:09:39 UTC
Not all projects use 'releases' or consistent naming conventions. Every account/repository on the other hand can have a tarball created/fetched via tag or hash name consistently using that system. Consider it a very solid baseline that does most if not all of the work for you.
Comment 13 commit-hook freebsd_committer freebsd_triage 2014-07-07 04:44:15 UTC
A commit references this bug:

Author: koobs
Date: Mon Jul  7 04:44:08 UTC 2014
New revision: 361021
URL: http://svnweb.freebsd.org/changeset/ports/361021

Log:
  sysutils/respond: Update to 1.3, Add LICENSE

  - Update to 1.3
  - Switch to GITHUB for distribution files
  - Add LICENSE (BSD2CLAUSE)
  - Remove patch-Makefile (upstreamed)
  - pkg-descr: Update WWW: URL

  Changes:

    https://github.com/joukewitteveen/respond/blob/1.3/NEWS

  PR:		191434
  Submitted by:	Jouke Witteveen (maintainer)

Changes:
  head/sysutils/respond/Makefile
  head/sysutils/respond/distinfo
  head/sysutils/respond/files/
  head/sysutils/respond/pkg-descr
Comment 14 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-07 04:47:49 UTC
All sorted Jouke, thanks for the effort you put in :)