Bug 191463 - subversion-gnome-keyring and subversion-kwallet are not used by subversion
Summary: subversion-gnome-keyring and subversion-kwallet are not used by subversion
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-28 16:36 UTC by Raphael Kubo da Costa
Modified: 2014-06-30 14:25 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-28 16:36:08 UTC 
These days, devel/subversion is always built with gnome-keyring and kwallet support disabled.

This means code such as svn_auth_get_platform_specific_provider() in subversion/libsvn_subr/auth.c never call the functions in the plugins because SVN_HAVE_GNOME_KEYRING and SVN_HAVE_KWALLET are off in subversion/svn_private_config.h, and so even if subversion-kwallet (or gnome-keyring) are installed they are not used for authentication.
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-06-30 14:24:13 UTC 
A commit references this bug:

Author: lev
Date: Mon Jun 30 14:24:05 UTC 2014
New revision: 359849
URL: http://svnweb.freebsd.org/changeset/ports/359849

Log:
   Fix KWallet / GNOMe Keyring integration: eanble code in "main" libraries
   as it doesn't call any functions from KWallet/Keyring directly but
   should be enabled to load plugins dynamically.

  PR:	191463
  Submitted by:	Raphael Kubo da Costa

Changes:
  head/devel/subversion/Makefile
Comment 2 Lev A. Serebryakov freebsd_committer freebsd_triage 2014-06-30 14:25:10 UTC 
Fixed, thanks!