Bug 191645 - [ staging ] sysutils/apcupsd
Summary: [ staging ] sysutils/apcupsd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-05 23:17 UTC by Dan Lukes
Modified: 2014-07-06 13:14 UTC (History)
1 user (show)

See Also:

Attachments
Makefile (4.52 KB, text/plain)
2014-07-05 23:17 UTC, Dan Lukes 		no flags Details
pkg-plist (2.07 KB, text/plain)
2014-07-05 23:17 UTC, Dan Lukes 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2014-07-05 23:17:47 UTC 
Created attachment 144440 [details]
Makefile

sysutils/apcupsd require staging or will be removed

How-To-Repeat:
N/A

Fix:
Replace Makefile and pkg-plist by the one attached here. Run
	make makesum
Comment 1 Dan Lukes 2014-07-05 23:17:47 UTC 
Created attachment 144441 [details]
pkg-plist
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2014-07-06 00:17:42 UTC 
BROKEN=     no distinfo provided for some of the distfiles

In addition to your patch not updating distinfo, you didn't resolve that problem, so the port is still broken.

Dan, please submit your patches as patches (i.e. output from diff)... it's harder to review it this way.
Comment 3 Dan Lukes 2014-07-06 08:17:14 UTC 
(In reply to Adam Weinberger from comment #2)
> Dan, please submit your patches as patches (i.e. output from diff)... it's
> harder to review it this way.

I considered them so different, e.g. diff so unreadable to be useful (and it's not so hard to run diff by self). But OK, I will submit future PR as diffs despite it.

> In addition to your patch not updating distinfo, you didn't resolve that
> problem, so the port is still broken.
 
Please read and follow 'Fix' instructions. The problem you mentioned has been addressed and solved here.
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2014-07-06 13:14:36 UTC 
Committed with modifications, thanks.