Bug 191708 - [ staging ] net-mgmt/routers2-extensions
Summary: [ staging ] net-mgmt/routers2-extensions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-07 16:44 UTC by Dan Lukes
Modified: 2014-07-29 00:18 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2014-07-07 16:44:08 UTC 
net-mgmt/routers2-extensions require staging or will be removed

Fix:
Patch is attached. 

--- net-mgmt/routers2-extensions/Makefile.orig	2014-07-07 18:38:24.000000000 +0200
+++ net-mgmt/routers2-extensions/Makefile	2014-07-07 18:39:21.000000000 +0200
@@ -22,23 +22,22 @@
 
 NO_BUILD=	YES
 
-NO_STAGE=	yes
 post-patch:
 	for file in *.cgi ; do \
 		${REINPLACE_CMD} -e 's|%%LOCALBASE%%|${LOCALBASE}|' ${WRKSRC}/$$file; \
 	done
 
 do-install:
-		${MKDIR} -m 755 ${PREFIX}/www/routers2/extensions
+		${MKDIR} -m 755 ${STAGEDIR}${PREFIX}/www/routers2/extensions
 
 .if !defined(NOPORTDOCS)
-		${MKDIR} -m 755 ${DOCSDIR}
+		${MKDIR} -m 755 ${STAGEDIR}${DOCSDIR}
 		for file in README *.txt extension.cgi.pl; do \
-			${INSTALL_DATA} ${WRKSRC}/$$file ${DOCSDIR}; \
+			${INSTALL_DATA} ${WRKSRC}/$$file ${STAGEDIR}${DOCSDIR}; \
 		done
 .endif
 		for file in *.cgi; do \
-			${INSTALL_SCRIPT} ${WRKSRC}/$$file ${PREFIX}/www/routers2/extensions; \
+			${INSTALL_SCRIPT} ${WRKSRC}/$$file ${STAGEDIR}${PREFIX}/www/routers2/extensions; \
 		done
 
 .include <bsd.port.mk>
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-07-08 01:32:02 UTC 
Notify maintainer.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-07-26 07:33:22 UTC 
maintainer approval not required for staging.

Dan, it's helpful to resubmit patch as an attachment.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-29 00:17:30 UTC 
A commit references this bug:

Author: marino
Date: Tue Jul 29 00:16:33 UTC 2014
New revision: 363279
URL: http://svnweb.freebsd.org/changeset/ports/363279

Log:
  Stage net-mgmt/routers2-extensions and cleanup

   * stage support
   * use PORTDOCS (remove from pkg-plist)
   * use DOCS instead of NOPORTDOCS
   * get rid of 3 unnecessary for loops

  PR:		191708
  Submitted by:	Dan Lukes
  Modified++:	marino

Changes:
  head/net-mgmt/routers2-extensions/Makefile
  head/net-mgmt/routers2-extensions/pkg-plist
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-29 00:18:41 UTC 
I tweaked your patch a bit.