Bug 191804 - New port: www/vimb The vim like browser, version 2.5
Summary: New port: www/vimb The vim like browser, version 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: John Marino
URL:
Keywords:
: 190064 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-11 14:22 UTC by Anonymized Account
Modified: 2014-08-09 23:26 UTC (History)
2 users (show)

See Also:


Attachments
file.shar (1.95 KB, application/x-shar)
2014-07-11 14:22 UTC, Anonymized Account
no flags Details
Corrected, updated to version 2.6 (1.88 KB, text/plain)
2014-07-29 08:19 UTC, Anonymized Account
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anonymized Account freebsd_committer freebsd_triage 2014-07-11 14:22:56 UTC
Created attachment 144576 [details]
file.shar

Vimb is a web browser that behaves like Vimprobable, but with some paradigms
	from dwb and hopefully a cleaner code base.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2014-07-14 15:38:50 UTC
There's no need to use bsd.options.mk here.

GTK2_LIB_DEPENDS=    libwebkitgtk-1.0.so:${PORTS...
GTK2_USE=    GNOME=gtk20

...
GTK3_MAKE_ENV=    GTK="3"


Also, please run "portlint -C" on your port. You have a number of problems, including spaces instead of tabs, manpages that aren't listed with .gz, and a plist that could easily be listed in PLIST_FILES.
Comment 2 Anonymized Account freebsd_committer freebsd_triage 2014-07-29 08:19:42 UTC
Created attachment 145116 [details]
Corrected, updated to version 2.6
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-07 15:02:39 UTC
*** Bug 190064 has been marked as a duplicate of this bug. ***
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-09 22:41:01 UTC
You don't need:

.ifndef (WITH_DEBUG)
  ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/vimb
.endif

If WITH_DEBUG is defined, STRIP_CMD doesn't equal "strip", it equals "true", which is a no-op.

Have you ever seen any other port do that to STRIP_CMD?
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-09 23:09:32 UTC
This is why I require poudriere logs for new ports now:

===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/man/man1/vimb.1
Error: Orphaned: @dirrmtry share/man/man1
Error: Orphaned: @dirrmtry share/man
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1


If I had to guess, the port is installing the man page in share/man/man1 and then you install it again at man/man1 in the post-install target, so there are two man pages.

Since there are only two files and since you are using the post-install target anyway, we'll just override the do-install target and remove the post-install.

This is where I was going to punt it back to you again, but since it's trivial I'll try it first.  (It wastes less of my time)
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-09 23:24:53 UTC
A commit references this bug:

Author: marino
Date: Sat Aug  9 23:24:45 UTC 2014
New revision: 364484
URL: http://svnweb.freebsd.org/changeset/ports/364484

Log:
  Add new port www/vimb

  PR:		191804
  Submitted by:	mike.d.ft402 (gmail.com)

  Vimb is a web browser that behaves like Vimprobable, but with some
  paradigms from dwb and hopefully a cleaner code base. The goal of Vimb is
  to build a completely keyboard-driven, efficient and pleasurable browsing
  experience with low memory and cpu usage.

Changes:
  head/www/Makefile
  head/www/vimb/
  head/www/vimb/Makefile
  head/www/vimb/distinfo
  head/www/vimb/pkg-descr
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-09 23:26:42 UTC
Port is live now, thanks!