Bug 192263 - [new port] devel/p5-Log-Defer - Deferred logs and timers
Summary: [new port] devel/p5-Log-Defer - Deferred logs and timers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-perl (Nobody)
URL:
Keywords:
Depends on:
Blocks: 192265
  Show dependency treegraph
 
Reported: 2014-07-30 04:22 UTC by Bill Brinzer
Modified: 2014-08-17 16:50 UTC (History)
1 user (show)

See Also:


Attachments
p5-Log-Defer.shar (2.76 KB, text/plain)
2014-07-30 04:22 UTC, Bill Brinzer
no flags Details
p5-Log-Defer.shar (3.03 KB, text/plain)
2014-08-01 18:56 UTC, Bill Brinzer
no flags Details
p5-Log-Defer-0.311-10.0-amd64.log (8.09 KB, text/plain)
2014-08-01 18:57 UTC, Bill Brinzer
no flags Details
p5-Log-Defer-0.311.log (10.64 KB, text/plain)
2014-08-04 15:04 UTC, Bill Brinzer
no flags Details
p5-Log-Defer.shar (2.78 KB, text/plain)
2014-08-04 16:31 UTC, Bill Brinzer
no flags Details
p5-Log-Defer-0.311.log (10.07 KB, text/plain)
2014-08-04 16:32 UTC, Bill Brinzer
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Brinzer 2014-07-30 04:22:56 UTC
Created attachment 145139 [details]
p5-Log-Defer.shar

This is a dependency of new port devel/p5-AnyEvent-Task, which I plan to submit shortly.

This module lets you defer log processing in two ways:

* Defer recording of log messages until some "transaction" has completed
* Defer rendering of log messages

This module doesn't actually write out logs! To use this module for normal
logging purposes you also need a logging library.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-30 08:01:31 UTC
Can you describe what testing you performed on this?

poudriere?  redports?  make check-plist?
(The first one is best)
Comment 2 Bill Brinzer 2014-08-01 18:56:59 UTC
Created attachment 145220 [details]
p5-Log-Defer.shar

Replacement .shar file with the following changes suggested by poudriere:

  - Add missing @dirrmtry statements for lib/perl5, etc.
  - Set NO_ARCH= yes.
Comment 3 Bill Brinzer 2014-08-01 18:57:37 UTC
Created attachment 145221 [details]
p5-Log-Defer-0.311-10.0-amd64.log

"poudriere testport" logs for this port on 10.0-RELEASE amd64.

I also have logs for 9.3-RELEASE amd64, and the i386 flavors of these releases, if you want them (but I'm guessing they are not necessary since the port is CPU independent as poudriere pointed out).
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-01 19:06:11 UTC
Ah, I see from the comment history that I didn't specify "-t" on bulk or "poudriere testport" but rather asked what was done.

Would you mind rerunning the build with -t to enable stage-qa tests?
Comment 5 Bill Brinzer 2014-08-01 19:23:12 UTC
Hm, not sure why the QA logs are missing. I will re-run with "poudriere bulk -t" and post the results here (per bug #191713 comment #6).
Comment 6 Bill Brinzer 2014-08-04 15:04:11 UTC
Created attachment 145343 [details]
p5-Log-Defer-0.311.log

Attached is a log with stage-qa output, from "poudriere bulk -t".
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-04 15:12:28 UTC
This one also looks aggressive in directory removal in PLIST:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
Warning: Possibly owned by dependency: @dirrmtry %%PERL5_MAN3%%
Warning: Possibly owned by dependency: @dirrmtry lib/perl5/%%PERL_VER%%/man
Warning: Possibly owned by dependency: @dirrmtry lib/perl5/%%PERL_VER%%
Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto
Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%
Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%
Warning: Possibly owned by dependency: @dirrmtry lib/perl5/site_perl
Warning: Possibly owned by dependency: @dirrmtry lib/perl5
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done
Comment 8 Bill Brinzer 2014-08-04 15:26:07 UTC
OK, will fix.
Comment 9 Bill Brinzer 2014-08-04 16:31:55 UTC
Created attachment 145359 [details]
p5-Log-Defer.shar

New shar file with corrected pkg-plist.
Comment 10 Bill Brinzer 2014-08-04 16:32:41 UTC
Created attachment 145360 [details]
p5-Log-Defer-0.311.log

stage-qa output for attachment #145359 [details].
Comment 11 John Marino freebsd_committer freebsd_triage 2014-08-04 16:46:48 UTC
Looks good, patch-ready!
Comment 12 John Marino freebsd_committer freebsd_triage 2014-08-11 08:36:47 UTC
Assigning to perl@ per new policy
Comment 13 commit-hook freebsd_committer freebsd_triage 2014-08-17 16:49:59 UTC
A commit references this bug:

Author: pi
Date: Sun Aug 17 16:49:46 UTC 2014
New revision: 365203
URL: http://svnweb.freebsd.org/changeset/ports/365203

Log:
  New port: devel/p5-Log-Defer

  This module lets you defer log processing in two ways:

  - Defer recording of log messages until some "transaction" has completed
  - Defer rendering of log messages

  This module doesn't actually write out logs! To use this module for normal
  logging purposes you also need a logging library.

  WWW: http://search.cpan.org/dist/Log-Defer/

  PR:		192263
  Submitted by:	bill.brinzer@gmail.com

Changes:
  head/devel/Makefile
  head/devel/p5-Log-Defer/
  head/devel/p5-Log-Defer/Makefile
  head/devel/p5-Log-Defer/distinfo
  head/devel/p5-Log-Defer/pkg-descr
  head/devel/p5-Log-Defer/pkg-plist
Comment 14 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-17 16:50:27 UTC
Committed, thanks!