Created attachment 145185 [details] fix games/tome4 with premake4 4.4-beta5 This fixes games/tome4 after devel/premake4 update to 4.4-beta5 The new premake4 seems to hardcode "gcc" regardless of CC, command line flags, etc., and not in a way environment for gmake can override this. The patch fixes output of premake4 before running gmake. It a no-op on systems with premake4 4.3 and doesn't change the package on systems where tome4 already builds.
The r363824 to games/tome4 can be reverted: it doesn't fix the build and is unnecessary. It adjusts the Windows build target and two makefiles that are not used during the build.
Please revert r363824. It adds an extra operation to the port build and is a no-op for both the build and the resulting package.
A commit references this bug: Author: adamw Date: Sun Aug 3 15:11:27 UTC 2014 New revision: 363908 URL: http://svnweb.freebsd.org/changeset/ports/363908 Log: This fixes games/tome4 after devel/premake4 update to 4.4-beta5 The new premake4 seems to hardcode "gcc" regardless of CC, command line flags, etc., and not in a way environment for gmake can override this. The patch fixes output of premake4 before running gmake. It a no-op on systems with premake4 4.3 and doesn't change the package on systems where tome4 already builds. PR: 192291 Palindromic PR: yes Submitted by: maintainer Changes: head/games/tome4/Makefile
Done. Can you also take a look at the do-install? ${INSTALL} -m 0755 is unusual. Would one of ${INSTALL_PROGRAM} or ${INSTALL_SCRIPT} work instead?
Using ${INSTALL_SCRIPT} to install tome4 sounds great. I didn't know ${INSTALL_SCRIPT} existed at the time. I noticed that it installs the script with a more conservative (better) -m 0555 as well. I will include this with the next fix or update to games/tome4 or you can change it now, if you would like.
Waiting for the next change might be worthwhile, since this would need a PORTREVISION bump (changes package).