Bug 192385 - [PATCH] graphics/cimg: DIST_SUBDIR dependent on version (and PORTREVISION)
Summary: [PATCH] graphics/cimg: DIST_SUBDIR dependent on version (and PORTREVISION)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-04 19:39 UTC by Dmitry Marakasov
Modified: 2014-08-15 12:29 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2014-08-04 19:39:53 UTC
cimg has DIST_SUBDIR=    ${PORTNAME}-${PORTVERSION}_${PORTREVISION}

Is there reason for subdir in if there is than is there a reason for
subdir to contain port version, especially revision?

The latter is the worst as it forces users to redownload distfile
with every portrevsion change. It's also error prone (committers
do not expect to update distinfo after PORTREVISION bump) - I've
just fixed such error.

I suggest to demove DIST_SUBDIR or atlest to strip it to ${PORTNAME}

Port maintainer (thierry@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-04 21:28:14 UTC
ASSIGN to maintainer
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-08-04 22:30:16 UTC
This is on purpose: unfortunately, this port's tarball is often rerolled after a release without bumping the version number. In this case, I bump the PORTREVISION and update the port with the new tarball.

Of course, there is a problem when PORTREVISION is bumped for a different reason.
I'm going to think about something like:

DIST_SUBDIR=    ${PORTNAME}-${PORTVERSION}_${TARBALLREVISION}
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2014-08-15 12:29:01 UTC
Fixed. Thanks for the reminder!
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-08-15 12:29:01 UTC
A commit references this bug:

Author: thierry
Date: Fri Aug 15 12:28:06 UTC 2014
New revision: 364967
URL: http://svnweb.freebsd.org/changeset/ports/364967

Log:
  Don't force to fetch again the tarball after a PORTREVISION's bump.

  PR:		ports/192385
  Submitted by:	amdmi3

Changes:
  head/graphics/cimg/Makefile