Bug 192698 - [patch] textproc/teckit fails to build with lang/gcc47
Summary: [patch] textproc/teckit fails to build with lang/gcc47
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-16 04:23 UTC by Justin Hibbits
Modified: 2014-08-16 13:50 UTC (History)
2 users (show)

See Also:

Attachments
Patch to fix textproc/teckit (to be dropped into files/) (246 bytes, patch)
2014-08-16 04:23 UTC, Justin Hibbits 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer freebsd_triage 2014-08-16 04:23:20 UTC 
Created attachment 145854 [details]
Patch to fix textproc/teckit (to be dropped into files/)

When building with lang/gcc47 (USE_GCC=yes) I see the following build failure.  The attached patch fixes it (can be dropped into a yet-to-be-created files/):


../source/Compiler.cpp: In function 'char* TECkit_GetTECkitName(UInt32)':
../source/Compiler.cpp:212:32: error: 'sprintf' was not declared in this scope
../source/Compiler.cpp: In function 'const char* asHex(UInt32, short int)':
../source/Compiler.cpp:349:34: error: 'sprintf' was not declared in this scope
../source/Compiler.cpp: In function 'const char* asDec(UInt32)':
../source/Compiler.cpp:357:24: error: 'sprintf' was not declared in this scope
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-16 07:05:47 UTC 
Hi Justin,
You normally provide the patch to the *port* not the software, so your diff would create the patch complete with name.  It's less work for whomever claims the port.

I think "svn patch" would create the files directory automatically so that shouldn't be a problem.

But since it's just one patch and not more I'll go ahead and notify the maintainer to get his approval.
Comment 2 Nikola Lečić 2014-08-16 08:19:26 UTC 
I approve this, of course. Justin, thank you very much.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-16 08:20:59 UTC 
maintain has approved; it's patch-ready
Comment 4 Nikola Lečić 2014-08-16 08:23:56 UTC 
While we are here, this port has an opened PR:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191120
Maybe you could commit these two improvements together?
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-16 09:48:14 UTC 
A commit references this bug:

Author: marino
Date: Sat Aug 16 09:47:25 UTC 2014
New revision: 365070
URL: http://svnweb.freebsd.org/changeset/ports/365070

Log:
  textproc/teckit: Add header to fix build on lang/gcc47

  PR:		192698
  Submitted by:	Justin Hibbits
  Approved by:	maintainer (Nikola Lecic)

Changes:
  head/textproc/teckit/files/
  head/textproc/teckit/files/patch-source_Compiler.cpp
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-16 09:50:30 UTC 
(In reply to Nikola Lečić from comment #4)
> While we are here, this port has an opened PR:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191120
> Maybe you could commit these two improvements together?

Opportunistic, aren't you? :)
Comment 7 Nikola Lečić 2014-08-16 13:50:25 UTC 
(In reply to John Marino from comment #6)
> (In reply to Nikola Lečić from comment #4)
> > While we are here, this port has an opened PR:
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191120
> > Maybe you could commit these two improvements together?
> 
> Opportunistic, aren't you? :)

Indeed... but that's still a lot nicer than asking for commit that 2-months old PR first before approving this new one. :)

Anyway, thanks for taking 191120.