Bug 192700 - [MAINTAINER] net/ndpi: update to 1.5.0
Summary: [MAINTAINER] net/ndpi: update to 1.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on: 190351 192687
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-16 08:49 UTC by Muhammad Moinur Rahman
Modified: 2014-08-20 20:15 UTC (History)
2 users (show)

See Also:

Attachments
patch for ndpi-1.5.0 (5.43 KB, patch)
2014-08-16 08:49 UTC, Muhammad Moinur Rahman 		no flags Details | Diff
patch for ndpi-1.5.0 (5.27 KB, patch)
2014-08-16 10:18 UTC, Muhammad Moinur Rahman 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-16 08:49:00 UTC 
Created attachment 145858 [details]
patch for ndpi-1.5.0

- Update to 1.5.0

Poudriere logs:
http://pdr.s.ubze.ro/bulk/latest-per-pkg/ndpi/1.5.0/
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-16 09:32:15 UTC 
this looks seriously suspicious:

29	.if ${OSVERSION} < 1000000
30	BUILD_DEPENDS+=	llvm-config33:${PORTSDIR}/devel/llvm33 \
31			clang++33:${PORTSDIR}/lang/clang33
32	CC=		clang33
33	CXX=		clang++33
34	.endif

you can't use USES=compiler:<option> ?

OSVERSION combined with compiler specification is a red flag
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-16 09:34:03 UTC 
What's an alternative for USE_GCC=any for CLANG?

(In reply to John Marino from comment #1)
> this looks seriously suspicious:
> 
> 29	.if ${OSVERSION} < 1000000
> 30	BUILD_DEPENDS+=	llvm-config33:${PORTSDIR}/devel/llvm33 \
> 31			clang++33:${PORTSDIR}/lang/clang33
> 32	CC=		clang33
> 33	CXX=		clang++33
> 34	.endif
> 
> you can't use USES=compiler:<option> ?
> 
> OSVERSION combined with compiler specification is a red flag
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-16 09:36:57 UTC 
answer these questions - 
what are you trying to solve?
Why are you explicitly specifying clang?

Read over Mk/Uses/compiler.mk and maybe that will trigger some ideas.
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-16 09:47:48 UTC 
The port doesn't build with gcc .. It needs clang. So for 8 and 9 I need clang compiler.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-16 10:00:00 UTC 
(In reply to Muhammad Moinur Rahman from comment #4)
> The port doesn't build with gcc .. It needs clang. So for 8 and 9 I need
> clang compiler.

1) why?
2) Did you review compilers.mk yet?

It describes the characteristics needed, not a specific compiler.
Against, assigning a compiler per OSVERSION is heavily frowned upon.
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-16 10:07:27 UTC 
Thx for the ideas. Will update the patch once the poudriere builder finishes.

(In reply to John Marino from comment #5)
> (In reply to Muhammad Moinur Rahman from comment #4)
> > The port doesn't build with gcc .. It needs clang. So for 8 and 9 I need
> > clang compiler.
> 
> 1) why?
> 2) Did you review compilers.mk yet?
> 
> It describes the characteristics needed, not a specific compiler.
> Against, assigning a compiler per OSVERSION is heavily frowned upon.
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-16 10:18:08 UTC 
Created attachment 145863 [details]
patch for ndpi-1.5.0
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-16 10:21:59 UTC 
okay, much better.

There's not "install-strip" target in the vendor makefile perchance is there?
Comment 9 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-16 10:25:54 UTC 
No.
(In reply to John Marino from comment #8)
> okay, much better.
> 
> There's not "install-strip" target in the vendor makefile perchance is there?
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-16 10:27:05 UTC 
ok, I've hassled you enough this morning.  Moving to patch-ready.
Comment 11 commit-hook freebsd_committer freebsd_triage 2014-08-20 20:15:02 UTC 
A commit references this bug:

Author: wg
Date: Wed Aug 20 20:14:56 UTC 2014
New revision: 365509
URL: http://svnweb.freebsd.org/changeset/ports/365509

Log:
  net/ndpi: update to 1.5.0

  PR:		192700
  Submitted by:	maintainer

Changes:
  head/net/ndpi/Makefile
  head/net/ndpi/distinfo
  head/net/ndpi/files/
  head/net/ndpi/files/patch-configure
  head/net/ndpi/files/patch-example_Makefile.in
  head/net/ndpi/pkg-plist