Bug 192742 - www/chromium : file choser (file upload) not available
Summary: www/chromium : file choser (file upload) not available
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-17 13:54 UTC by Christoph Moench-Tegeder
Modified: 2014-08-18 19:15 UTC (History)
3 users (show)

See Also:

Attachments
add FreeBSD (OS_FREEBSD) to file choser logic. (913 bytes, patch)
2014-08-17 13:54 UTC, Christoph Moench-Tegeder 		no flags Details | Diff
patch-ui__shell_dialogs__select_file_dialog.cc (917 bytes, patch)
2014-08-17 15:44 UTC, Carlos J Puga Medina 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2014-08-17 13:54:49 UTC 
Created attachment 145921 [details]
add FreeBSD (OS_FREEBSD) to file choser logic.

When trying to upload a file using chromium, instead of showing the file choser, nothing happens. Chromium logs:

[29528:385901568:0817/022602:ERROR:select_file_dialog.cc(94)] Not implemented reached in static scoped_refptr<ui::SelectFileDialog> ui::SelectFileDialog::Create(ui::SelectFileDialog::Listener *, ui::SelectFilePolicy *)

In ui/shell_dialogs/select_file_dialog.cc, the #ifdef orgy has no idea about FreeBSD. Attached patch fixes that.

patch-ui__shell_dialogs__select_file_dialog.cc can be dropped into chromium/files/.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2014-08-17 15:18:48 UTC 
over to maintainers
Comment 2 Carlos J Puga Medina 2014-08-17 15:44:24 UTC 
Created attachment 145924 [details]
patch-ui__shell_dialogs__select_file_dialog.cc

Fix submitted patch according to apply correctly.

Thanks!
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2014-08-18 19:15:06 UTC 
Fixed in r365341, thanks for the report.