Bug 192779 - www/xombrero -1.6.3 build failed settings.o
Summary: www/xombrero -1.6.3 build failed settings.o
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 12:07 UTC by Admir Mehic
Modified: 2016-05-05 21:54 UTC (History)
8 users (show)

See Also:
zeising: maintainer-feedback+
zeising: merge-quarterly+


Attachments
Xombrero (GTK3) backtrace (1.30 KB, text/plain)
2015-10-08 08:11 UTC, Marko Turk
no flags Details
svn-diff_www_xombrero-1.6.4 (2.26 KB, patch)
2016-01-17 09:44 UTC, w.schwarzenfeld
no flags Details | Diff
portlint_www_xombrero-1.6.4 (793 bytes, text/plain)
2016-01-17 09:45 UTC, w.schwarzenfeld
no flags Details
poudriere_xombrero-1.6.4 (56.56 KB, text/plain)
2016-01-17 12:53 UTC, w.schwarzenfeld
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Admir Mehic 2014-08-18 12:07:12 UTC
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
*** [../settings.o] Error code 1

make[2]: stopped in /usr/ports/www/xombrero/work/xombrero-1.6.3/freebsd
--- ../xombrero.o ---
../xombrero.c:6232:23: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion]
        char                    *tokens[3] = {'\0'};
                                              ^~~~
1 warning generated.
1 error

make[2]: stopped in /usr/ports/www/xombrero/work/xombrero-1.6.3/freebsd
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-18 18:32:05 UTC
over to maintainer.
Comment 2 web 2015-02-13 21:34:10 UTC
tried to build www/xombrero using: # portmaster -K -B -D www/xombrero
but I got this error:

--- ../settings.o ---
In file included from ../settings.c:25:
../tooltip.h:182:32: warning: missing terminating '"' character [-Winvalid-pp-token]
#define TT_ENABLE_FAVICON_TABS  "When enabled (
                                ^
../settings.c:530:134: error: expected expression
        { "enable_favicon_tabs",        XT_S_BOOL, 0,           &enable_favicon_tabs, NULL, NULL, NULL, set_enable_favicon_tabs, check_enable_favicon_tabs, TT_ENABLE_FAVICON_TABS },
                                                                                                                                                            ^
../tooltip.h:182:32: note: expanded from macro 'TT_ENABLE_FAVICON_TABS'
../settings.c:531:127: error: use of undeclared identifier 'TT_ENABLE_JS_AUTORUN'
        { "enable_js_autorun",          XT_S_BOOL, 0,           &enable_js_autorun, NULL, NULL, NULL, set_enable_js_autorun, check_enable_js_autorun, TT_ENABLE_JS_AUTORUN },
                                                                                                                                                      ^
../settings.c:532:134: error: use of undeclared identifier 'TT_ENABLE_JS_WHITELIST'
        { "enable_js_whitelist",        XT_S_BOOL, 0,           &enable_js_whitelist, NULL, NULL, NULL, set_enable_js_whitelist, check_enable_js_whitelist, TT_ENABLE_JS_WHITELIST },
                                                                                                                                                            ^
../settings.c:533:134: error: use of undeclared identifier 'TT_ENABLE_LOCALSTORAGE'
        { "enable_localstorage",        XT_S_BOOL, 0,           &enable_localstorage, NULL, NULL, NULL, set_enable_localstorage, check_enable_localstorage, TT_ENABLE_LOCALSTORAGE },
                                                                                                                                                            ^
../settings.c:534:150: error: use of undeclared identifier 'TT_ENABLE_PLUGIN_WHITELIST'
        { "enable_plugin_whitelist",    XT_S_BOOL, 0,           &enable_plugin_whitelist, NULL, NULL, NULL, set_enable_plugin_whitelist, check_enable_plugin_whitelist, TT_ENABLE_PLUGIN_WHITELIST },
                                                                                                                                                                        ^
../settings.c:535:115: error: use of undeclared identifier 'TT_ENABLE_PLUGINS'
        { "enable_plugins",             XT_S_BOOL, 0,           &enable_plugins, NULL, NULL, NULL, set_enable_plugins, check_enable_plugins, TT_ENABLE_PLUGINS },
                                                                                                                                             ^
../settings.c:536:115: error: use of undeclared identifier 'TT_ENABLE_SCRIPTS'
        { "enable_scripts",             XT_S_BOOL, 0,           &enable_scripts, NULL, NULL, NULL, set_enable_scripts, check_enable_scripts, TT_ENABLE_SCRIPTS },
                                                                                                                                             ^
../settings.c:537:107: error: use of undeclared identifier 'TT_ENABLE_SOCKET'
        { "enable_socket",              XT_S_BOOL,XT_SF_RESTART,&enable_socket, NULL, NULL, NULL, NULL, check_enable_socket, TT_ENABLE_SOCKET },
                                                                                                                             ^
../settings.c:538:142: error: use of undeclared identifier 'TT_ENABLE_SPELL_CHECKING'
        { "enable_spell_checking",      XT_S_BOOL, 0,           &enable_spell_checking, NULL, NULL, NULL, set_enable_spell_checking, check_enable_spell_checking, TT_ENABLE_SPELL_CHECKING },
                                                                                                                                                                  ^
--- ../xombrero.o ---
cc -O2 -pipe -O2 -fno-strict-aliasing -pipe  -fstack-protector -O2 -fno-strict-aliasing -pipe   -I/usr/local/include/gtk-2.0 -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -D_THREAD_SAFE -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng16 -I/usr/local/include/pango-1.0  -I/usr/local/include/freetype2 -I/usr/local/include/harfbuzz -I/usr/local/include/webkitgtk-1.0 -I/usr/local/include/libsoup-2.4 -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/libxml2 -I/usr/local/include -I/usr/local/include/p11-kit-1   -Wall -I. -I.. -c ../xombrero.c
--- ../settings.o ---
../settings.c:539:150: error: use of undeclared identifier 'TT_ENABLE_STRICT_TRANSPORT'
        { "enable_strict_transport",    XT_S_BOOL, 0,           &enable_strict_transport, NULL, NULL, NULL, set_enable_strict_transport, check_enable_strict_transport, TT_ENABLE_STRICT_TRANSPORT },
                                                                                                                                                                        ^
../settings.c:540:82: error: use of undeclared identifier 'TT_ENCODING'
        { "encoding",                   XT_S_STR, 0, NULL,      &encoding, NULL, NULL, NULL, check_encoding, TT_ENCODING },
                                                                                                             ^
../settings.c:541:116: error: use of undeclared identifier 'TT_EXTERNAL_EDITOR'
        { "external_editor",            XT_S_STR,0, NULL,       &external_editor, NULL, NULL, set_external_editor, check_external_editor, TT_EXTERNAL_EDITOR },
                                                                                                                                          ^
../settings.c:542:105: error: use of undeclared identifier 'TT_FANCY_BAR'
        { "fancy_bar",                  XT_S_BOOL,XT_SF_RESTART,&fancy_bar, NULL, NULL, NULL, set_fancy_bar, check_fancy_bar, TT_FANCY_BAR },
                                                                                                                              ^
../settings.c:543:121: error: use of undeclared identifier 'TT_GNUTLS_PRIORITY_STRING'
        { "gnutls_priority_string",     XT_S_STR, 0, NULL, NULL,&s_gnutls_priority_string, NULL, NULL, check_gnutls_search_string, TT_GNUTLS_PRIORITY_STRING },
                                                                                                                                   ^
../settings.c:544:107: error: use of undeclared identifier 'TT_GUESS_SEARCH'
        { "guess_search",               XT_S_BOOL, 0,           &guess_search, NULL, NULL, NULL, set_guess_search, check_guess_search, TT_GUESS_SEARCH },
                                                                                                                                       ^
../settings.c:545:83: error: use of undeclared identifier 'TT_GUI_MODE'
        { "gui_mode",                   XT_S_STR, 0, NULL, NULL,&s_gui_mode, NULL, NULL, check_gui_mode, TT_GUI_MODE },
                                                                                                         ^
../settings.c:546:107: error: use of undeclared identifier 'TT_HISTORY_AUTOSAVE'
        { "history_autosave",           XT_S_BOOL, 0,           &history_autosave, NULL, NULL, NULL, NULL, check_history_autosave, TT_HISTORY_AUTOSAVE },
                                                                                                                                   ^
../settings.c:547:74: error: use of undeclared identifier 'TT_HOME'
        { "home",                       XT_S_STR, 0, NULL,      &home, NULL, NULL, set_home, check_home, TT_HOME },
                                                                                                         ^
../settings.c:548:98: error: use of undeclared identifier 'TT_HTTP_PROXY'
        { "http_proxy",                 XT_S_STR, 0, NULL,      &http_proxy, NULL, NULL, set_http_proxy, check_http_proxy, TT_HTTP_PROXY },
                                                                                                                           ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.
*** [../settings.o] Error code 1

make[2]: stopped in /usr/ports/www/xombrero/work/xombrero-1.6.3/freebsd
--- ../xombrero.o ---
../xombrero.c:6232:23: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion]
        char                    *tokens[3] = {'\0'};
                                              ^~~~
1 warning generated.
1 error

make[2]: stopped in /usr/ports/www/xombrero/work/xombrero-1.6.3/freebsd
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/www/xombrero
*** Error code 1

Stop.
make: stopped in /usr/ports/www/xombrero

===>>> make build failed for www/xombrero
===>>> Aborting update


===>>> You can restart from the point of failure with this command line:
       portmaster <flags> www/xombrero
Comment 3 Alastair Hogge 2015-06-09 23:27:04 UTC
(In reply to web from comment #2)
The errors relating to the TT_ defines can be fixed with adding
BUILD_DEPENDS= nroff:${PORTSDIR}/textproc/groff
to the port's Makefile.

As for the GTK stuff, I do not know.
Comment 4 Andrew Carson Gay 2015-08-20 16:43:04 UTC
I also have encountered the same error. Attempting a few work arounds now
Comment 5 Marko Turk 2015-10-08 08:11:55 UTC
Created attachment 161819 [details]
Xombrero (GTK3) backtrace
Comment 6 Marko Turk 2015-10-08 08:12:45 UTC
Hi,

xombrero (GTK3) binary pkg is broken, it segfaults on startup (the backtrace is attached). But it works if I compile it from ports with GTK2 option.

Compile from ports is broken, I had to change work/xombrero-1.6.3/freebsd/Makefile and add '../.*' to the xombrero target. Then it builds ok.

Also, after last pkg upgrade of all packages, html5 video stopped working in xombrero.

Has anyone had more luck with fixing this?
Comment 7 Niclas Zeising freebsd_committer freebsd_triage 2015-10-28 19:25:15 UTC
I'm looking into this, at least the compile issues.  Regarding the segfaults, I have no idea what causes them yet.  It might be some incompatibilities between GTK3 versions used upstream and the one in our ports tree.
Comment 8 w.schwarzenfeld 2016-01-17 09:44:37 UTC
Created attachment 165700 [details]
svn-diff_www_xombrero-1.6.4
Comment 9 w.schwarzenfeld 2016-01-17 09:45:13 UTC
Created attachment 165701 [details]
portlint_www_xombrero-1.6.4
Comment 10 w.schwarzenfeld 2016-01-17 09:59:54 UTC
Provide portlint, poudriere.log and svn-diff.
Found patch in:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203939
Comment 11 w.schwarzenfeld 2016-01-17 12:53:07 UTC
Created attachment 165707 [details]
poudriere_xombrero-1.6.4
Comment 12 Niclas Zeising freebsd_committer freebsd_triage 2016-01-17 19:48:33 UTC
I am still working on this.  There is some sort of race condition in the build, that makes it fail from time to time.
Comment 13 commit-hook freebsd_committer freebsd_triage 2016-05-05 21:45:16 UTC
A commit references this bug:

Author: rm
Date: Thu May  5 21:44:53 UTC 2016
New revision: 414668
URL: https://svnweb.freebsd.org/changeset/ports/414668

Log:
  www/xombrero: unbreak; update to 1.6.4

  This patch is cherry-picked from 4 different PRs and one upstream bug report [1]

  Changes are:
  - fix build and runtime (based on [1]). I also tried patches and solutions from
    PR's, but they didn't worked for some reason
  - update to 1.6.4
  - convert to options helpers and add other simplifications to Makefile
  - sync installed files with Makefile, bundled into distribution
  - add upstream patch to fix some GTK3 warnings

  This was tested both at build and runtime with both GTK versions.
  Also HTML5 video playback was tested - there was a report that it doesn't work.

  [1] https://github.com/conformal/xombrero/issues/131

  PR:		192779 203939 205646 209301
  Submitted by:	various persons

Changes:
  head/www/xombrero/Makefile
  head/www/xombrero/distinfo
  head/www/xombrero/files/patch-freebsd__Makefile
  head/www/xombrero/files/patch-xombrero.css
  head/www/xombrero/pkg-descr
  head/www/xombrero/pkg-plist
Comment 14 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-05-05 21:53:48 UTC
This was fixed in 1.6.4