Bug 192873 - [maintainer] math/asir2000 update
Summary: [maintainer] math/asir2000 update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-21 02:16 UTC by SaitoTomokatsu
Modified: 2014-08-28 13:59 UTC (History)
5 users (show)

See Also:

Attachments
math/asir2000 system update (20.75 KB, patch)
2014-08-21 02:19 UTC, SaitoTomokatsu 		no flags Details | Diff
math/asir2000 system update (3.62 KB, patch)
2014-08-28 01:56 UTC, SaitoTomokatsu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SaitoTomokatsu 2014-08-21 02:16:56 UTC 

    


    


      



        
          Comment 1
        

        
          SaitoTomokatsu

        

        
        

        
          2014-08-21 02:19:02 UTC
        

      






Created attachment 146100 [details]
math/asir2000 system update

    


    


      



        
          Comment 2
        

        
          John Marino

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-21 09:10:14 UTC
        

      






straightforward version update, moving to patch-ready

    


    


      



        
          Comment 3
        

        
          William Grzybowski

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-24 14:04:50 UTC
        

      






I don't like the idea of patches named patch-[ab]. They are non-descriptive.
Any chance you can describe the file being changed or group all of them in the same functionality patch?

This is a personal choice and it may not be documented anywhere, so if you don't want to do it thats acceptable.

    


    


      



        
          Comment 4
        

        
          Adam Weinberger

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-24 16:22:29 UTC
        

      






(In reply to William Grzybowski from comment #3)
> I don't like the idea of patches named patch-[ab]. They are non-descriptive.
> Any chance you can describe the file being changed or group all of them in
> the same functionality patch?

Yeah, absolutely not. I went through contortions to get all the patch-ab nonsense out of the ports tree. Saito, can you please update the patch with properly named patches?

    


    


      



        
          Comment 5
        

        
          John Marino

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-27 20:50:21 UTC
        

      






(In reply to William Grzybowski from comment #3)
> I don't like the idea of patches named patch-[ab]. They are non-descriptive.
> Any chance you can describe the file being changed or group all of them in
> the same functionality patch?
> 
> This is a personal choice and it may not be documented anywhere, so if you
> don't want to do it thats acceptable.


I would be surprised if it's not documented anywhere.  By now these old patch names have to be nearing extinction so I'm not sure it's acceptable to introduce new ones actually.

Saito, just rename the patch-[ab] patches with an updated patch and the PR can get moving again.

    


    


      



        
          Comment 6
        

        
          SaitoTomokatsu

        

        
        

        
          2014-08-28 01:56:46 UTC
        

      






Created attachment 146430 [details]
math/asir2000 system update

new asir2000 patch file

    


    


      



        
          Comment 7
        

        
          William Grzybowski

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-28 11:57:10 UTC
        

      






One last thing, did the previous maintainer accept the change as you the new maintainer?

    


    


      



        
          Comment 8
        

        
          John Marino

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-28 12:02:50 UTC
        

      






sorry, I didn't notice the port already had a maintainer otherwise I would have CC'd the current maintainer.

Also USE_BZIP2=yes is wrong.

    


    


      



        
          Comment 9
        

        
          Muhammad Moinur Rahman

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-28 12:58:29 UTC
        

      






Passing the maintainership without any check as the requestee is the original author of the application. Committer's are requested to check for proper poudriere /tinderbox/redports logs.

    


    


      



        
          Comment 10
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2014-08-28 13:59:36 UTC
        

      






A commit references this bug:

Author: wg
Date: Thu Aug 28 13:59:14 UTC 2014
New revision: 366404
URL: http://svnweb.freebsd.org/changeset/ports/366404

Log:
  math/asir2000: update to 20140819

  - Pass maintainership to submitter

  PR:		192873
  Submitted by:	Saito Tomokatsu
  Approved by:	maintainer

Changes:
  head/math/asir2000/Makefile
  head/math/asir2000/distinfo
  head/math/asir2000/files/patch-include_version.h