Bug 192981 - Hook up CONFIGURE_SHELL and MAKE_SHELL
Summary: Hook up CONFIGURE_SHELL and MAKE_SHELL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-24 22:25 UTC by Tijl Coosemans
Modified: 2014-09-07 17:59 UTC (History)
1 user (show)

See Also:

Attachments
b.p.m.shell.patch (556 bytes, patch)
2014-08-24 22:25 UTC, Tijl Coosemans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2014-08-24 22:25:35 UTC 
Created attachment 146234 [details]
b.p.m.shell.patch

Mk/bsd.port.mk defines CONFIGURE_SHELL and MAKE_SHELL but doesn't use them.  This patch fixes that.  No port currently uses these variables so this should be a no-op.  I'd like to set CONFIGURE_SHELL=${LOCALBASE}/bin/bash in games/crossfire-server/Makefile, because it runs configure with bash and that means the libtool script it generates also has to run with bash and for that to happen CONFIG_SHELL needs to be set to bash.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2014-08-25 21:09:59 UTC 
approved
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-08-26 07:41:23 UTC 
A commit references this bug:

Author: tijl
Date: Tue Aug 26 07:40:57 UTC 2014
New revision: 366194
URL: http://svnweb.freebsd.org/changeset/ports/366194

Log:
  Use CONFIGURE_SHELL and MAKE_SHELL to define SHELL and CONFIG_SHELL

  PR:		192981
  Approved by:	portmgr (antoine)

Changes:
  head/Mk/bsd.port.mk
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2014-09-06 11:52:55 UTC 
Really, devel/gcc-arm-embedded was affected by this change, as it propagates CONFIGURE_ENV and MAKE_ENV to sub-make :)
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2014-09-06 14:22:17 UTC 
Would adding CONFIGURE_SHELL and MAKE_SHELL to VAR_TO_SUBMAKE fix it?
Comment 5 Lev A. Serebryakov freebsd_committer freebsd_triage 2014-09-07 17:59:04 UTC 
I use custom submake configuration (as I need special processing of some variables), I add it to my harness. But it was hard to find why gmake complains about "-c" command :)