Bug 192994 - net/dhcprelay: rc.d script patch
Summary: net/dhcprelay: rc.d script patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-25 19:22 UTC by Denys Razumov
Modified: 2014-09-20 19:02 UTC (History)
2 users (show)

See Also:

Attachments
Patch for files/dhcprelay.in (591 bytes, patch)
2014-08-25 19:59 UTC, Denys Razumov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denys Razumov 2014-08-25 19:22:16 UTC 
dhcprelay doesn't start with rc.d script from port tree
my patch for script

--- ../../files/dhcprelay.in.orig       2014-05-11 13:03:32.000000000 +0300
+++ ../../files/dhcprelay.in            2014-08-25 21:56:06.000000000 +0300
@@ -15,16 +15,15 @@
 . /etc/rc.subr

 name=dhcprelay
-rcvar=dhcprelay_enable
+rcvar=${name}_enable
+
+load_rc_config ${name}
+
+: ${dhcprelay_enable="NO"}
+: ${dhcprelay_ifaces=""}

 pidfile=/var/run/${name}.pid
 command=%%PREFIX%%/bin/${name}
 command_args="${dhcprelay_ifaces} ${dhcprelay_server}"

-# echo $rc_flags
-
-load_rc_config ${name}
-
-dhcprelay_enable=${dhcprelay_enable:-"NO"}
-
 run_rc_command "$1"
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-25 19:57:33 UTC 
Hi Denys, please provide your patch as an attachment.
Comment 2 Denys Razumov 2014-08-25 19:59:59 UTC 
Created attachment 146271 [details]
Patch for files/dhcprelay.in
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-25 20:03:49 UTC 
Ask maintainer for Approval (he has 2 weeks)

This will require a revision increment as well.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-20 17:57:22 UTC 
maintainer timeout, approval no longer required.  Moving to patch-ready.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-09-20 19:01:51 UTC 
A commit references this bug:

Author: marino
Date: Sat Sep 20 19:01:47 UTC 2014
New revision: 368675
URL: http://svnweb.freebsd.org/changeset/ports/368675

Log:
  net/dhcprelay: Fix RC script

  PR:		192994
  Submitted by:	Denys Razumov
  Approved by:	maintainer timeout (~1 month)

Changes:
  head/net/dhcprelay/Makefile
  head/net/dhcprelay/files/dhcprelay.in
Comment 6 John Marino freebsd_committer freebsd_triage 2014-09-20 19:02:32 UTC 
Thanks!