Created attachment 146586 [details] Imperfect patch to add staging support and new maintaner for amanda-server/amanda-client The attached patch adds stage support to amanda-server (and amanda-client, which is a slave port of amanda-server). It also sets me as the maintainer (was unmaintained). It builds and runs OK on my 9-STABLE AMD64 fileserver, but there are some possible stage-related issues: 1) Amanda (upstream code) builds its own install-hook target which it uses to set setuid bits amongst other things, This isn't ideal and prevents packages being built as non-root amongst other things. I have tried to fix this but haven't had the time yet to figure it out so I have set NEEDS_ROOT in the Makefile for now. 2) Many reported orphans were added to the plist after several iterations of the patch, and I am not sure if I have set everything correctly so that files which will only be present given certain OPTIONS are set correctly in the plist and vice versa. Some of the reported orphans from make check-orphans seem to be false positives caused by the way the port splits up building the client and server. This is my first staging patch, so I expect errors. Please let me know if there is anything missing. -- Dylan
IIUC, you're submitting a patch that you know will not pass stage-qa testing? Are you asking for somebody to help you stage this? We can't use the PR as it is. Are you familiar with ports-mgmt/poudriere, and do you have reasonable hardware that can run it? that is an invaluable tool for this.
I'll have a look at it. Some things look wrong in the provided patch
(I've also posted to ports@ about this patch and some of the complications of the port that are making staging difficult.) Can you tell me if #1 be a problem for ports QA or just #2? It would be great if someone with more experience could look into this - I can't spend a lot of time on it right now (submitting my thesis in October) but at least some of the work is done and I intend to fix the problems with the port ASAP. I'm not familiar with poudriere, but will look into it when I can. I don't have access to any particularly powerful hardware, just a home server really.
A commit references this bug: Author: antoine Date: Sun Aug 31 13:14:08 UTC 2014 New revision: 366753 URL: http://svnweb.freebsd.org/changeset/ports/366753 Log: Stage support I merged the 2 plists to prevent orphans to be reported during make check-plist of misc/amanda-server, as it installs into stage some files already provided by misc/amanda-client Bump PORTREVISION as the install/deinstall scripts were revised PR: ports/193196 Changes: head/misc/amanda-client/Makefile head/misc/amanda-server/Makefile head/misc/amanda-server/files/pkg-install.client.in head/misc/amanda-server/pkg-plist head/misc/amanda-server/pkg-plist.client
Patch committed with some changes: - USES=charsetfix to prevent charset.alias file - CONFIGURE_ARGS+=--disable-installperms to allow staging as a regular user - @group/@mode in plist to fix the perms of the files that need setuid - hooked PKGINSTALL/DEINSTALL to the package for misc/amanda-server - added a PKGINSTALL/DEINSTALL script to replace previous post-install of misc/amanda-client