Bug 193205 - [MAINTAINER] math/py-pandas: Convert to USES=python
Summary: [MAINTAINER] math/py-pandas: Convert to USES=python
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 13:59 UTC by John W. O'Brien
Modified: 2014-09-22 13:49 UTC (History)
2 users (show)

See Also:


Attachments
Teach math/py-pandas to use USES=python instead of USE_PYTHON (783 bytes, patch)
2014-08-31 13:59 UTC, John W. O'Brien
no flags Details | Diff
Teach math/py-pandas to use USES=python instead of USE_PYTHON without concurrent (772 bytes, patch)
2014-09-01 15:00 UTC, John W. O'Brien
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2014-08-31 13:59:23 UTC
Created attachment 146600 [details]
Teach math/py-pandas to use USES=python instead of USE_PYTHON

Change log
==========

*   Adopt modernized python USES with applicable features


Note: I have not tested the efficacy of the 'concurrent' feature, but I see no reason why it would not work because math/py-pandas only installs files to PYTHONPREFIX_SITELIBDIR and _LICENSE_DIR (which is built from PKGNAME).
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2014-09-01 06:02:53 UTC
concurrent has to be used when some renaming has to occur to prevent conflict with package for a different version of python

as you noted, py-pandas installs only under python sitelibdir so it's not necessary
Comment 2 John W. O'Brien 2014-09-01 14:28:30 UTC
antoine: Ah, then maybe I don't really understand the purpose that knob serves. The 20140607 CHANGES entry states, "If set to yes, the knob indicates that the port can be installed for different python versions at the same time." This port can do that, and you say it doesn't need the knob. I'll update the patch to remove 'concurrent' and take my questions about it to the mailing list.
Comment 3 John W. O'Brien 2014-09-01 15:00:41 UTC
Created attachment 146630 [details]
Teach math/py-pandas to use USES=python instead of USE_PYTHON without concurrent
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-04 15:41:14 UTC
moving maintainer patch to patch-ready pool (test logs not available)
Comment 5 John W. O'Brien 2014-09-05 02:40:38 UTC
marino: Where are the cool kids generating their test logs these days? RedPorts often fails for me in unusual and discouraging ways (https://redports.org/buildarchive/20140905015900-58929/) that seem to be completely disconnected from the port I'm trying to test, and I've been advised not to post build logs from my own, limited poudriere environment to shield possibly-sensitive details (e.g. host names, user names, etc) from crawl-able, public view.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-09-22 13:42:40 UTC
A commit references this bug:

Author: robak
Date: Mon Sep 22 13:42:17 UTC 2014
New revision: 368922
URL: http://svnweb.freebsd.org/changeset/ports/368922

Log:
  math/py-pandas: convert to USES=python format

  PR:		193205
  Submitted by:	John W. O'Brien <john@saltant.com>
  Approved by:	mentors (implicit)

Changes:
  head/math/py-pandas/Makefile
Comment 7 Bartek Rutkowski freebsd_committer freebsd_triage 2014-09-22 13:49:26 UTC
Committed, thanks for your work!