Created attachment 146732 [details] netdisco-1.3.3.patch - unbreak with apache 2.4 - add license - better handling of config files Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
maintainer patch looks ok with a quick glance.
this is wrong: ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR} That should be happening in pkg-plist, not the stage directory
This PLIST_SUB stuff is wonky, redundant. It needs reworking to something more conventional.
There is still a lot of cruft here, I had to remove two obsolete REINPLACE_EXPR definitions that didn't do anything. I'm not going to touch the tmp-plist stuff, but that looks fairly old as well. I'm going to modernize this port a bit, but it needs more TLC after that.
There's no point in having: pre-install do-install post-install I'm going to group everything under "do-install" target
A commit references this bug: Author: marino Date: Thu Sep 25 20:41:38 UTC 2014 New revision: 369294 URL: http://svnweb.freebsd.org/changeset/ports/369294 Log: Unbreak on Apache24 and overhaul net-mgmt/netdisco PR: 193284 Submitted by: maintainer: dgeo (centrale-marseille.fr) Overhaul: marino There were numerous issues still existing even after provided patch was applied. I ended up completely overhauling the port. It's been tested with poudriere testport. Changes: head/net-mgmt/netdisco/Makefile head/net-mgmt/netdisco/pkg-plist
There were several redundancies, e.g. the sample files were installed 3 times and the USER/GROUP was defined twice. Please review the port in it's current state, I completely reworked the makefile and the pkg-plist has a few changes as well. Hopefully it matches the intent. Closing the PR now.