Created attachment 146798 [details] new port shar file DAV implementation.
Created attachment 146799 [details] test port log
Thanks for your submission Jingfen. Review items: * Leftover commented out items * DISTNAME unnecessary * LICENSE and LICENSE_FILE need values * Use ${PYTHON_PKGNAMEPREFIX}<name> for python RUN_DEPENDS checks unless they are for binaries. * GH_PROJECT defaults to ${PORTNAME} already * The github repository has git tags, use them over direct to commit hashes when they're available * pkg-descr only contains a hash value, please create a proper pkg-descr Additionally, Run your port through portlint -AC, and attach portlint output for this and future submissions.
Created attachment 146883 [details] portlint -AC output
Created attachment 146884 [details] diff to new shar
Created attachment 146885 [details] new shar file
(In reply to Kubilay Kocak from comment #2) > Thanks for your submission Jingfen. > > Review items: > > * Leftover commented out items > * DISTNAME unnecessary Removed. > * LICENSE and LICENSE_FILE need values License provided. > * Use ${PYTHON_PKGNAMEPREFIX}<name> for python RUN_DEPENDS checks unless > they are > for binaries. > * GH_PROJECT defaults to ${PORTNAME} already Fixed. > * The github repository has git tags, use them over direct to commit hashes > when > they're available By using tag name, the WRKDIR try to use tag, but by default it is use commit id. > * pkg-descr only contains a hash value, please create a proper pkg-descr Fixed. > > Additionally, > > Run your port through portlint -AC, and attach portlint output for this and > future submissions. provided.
Thank you for those updates Jingfeng. Set both GH_TAGNAME and GH_COMMIT, together they derive the correct DISTFILES, and WRKSRC/
Created attachment 146910 [details] 2nd updated shar file correct alignment and compile py code.
Created attachment 146911 [details] 2nd updated shar file
Created attachment 146941 [details] 3rd shar file
Created attachment 146942 [details] diff from first shar to updated shar
Created attachment 147233 [details] shar file target commit clean out
By contact the project leader, the this is comp of Seahub, which should follow Seahub license. So, it should be APACHE2.0
1) combine do-install and post-install. There is no reason to have two targets. 2) X @cd ${WRKSRC}/wsgidav/addons/seafile && ${COPYTREE_SHARE} . ${STAGEDIR}${PYTHON_SITELIBDIR}/wsgidav/addons/seafile Remove "@" and surround with "()" 3) X@dirrmtry %%PYTHON_SITELIBDIR%%/wsgidav/addons/seafile remove that line I'm moving this back to triage so it doesn't get lost again.
I didn't notice this was assigned to python, but it's been stuck two months so I'll take it over.
I'll try to fix this myself right now.
A commit references this bug: Author: marino Date: Thu Nov 6 20:11:20 UTC 2014 New revision: 372237 URL: https://svnweb.freebsd.org/changeset/ports/372237 Log: Add new port www/py-seafdav PR: 193314 Submitted by: Jingfeng Yan This addon provides seafile implementation for Web DAV server by utilizing WsgiDAV interface. Changes: head/www/Makefile head/www/py-seafdav/ head/www/py-seafdav/Makefile head/www/py-seafdav/distinfo head/www/py-seafdav/pkg-descr head/www/py-seafdav/pkg-plist
This makefile had a major bug: the GH_TAGNAME has $PORTVERSION in it, not $PORTNAME The last python command looks funny to me, but it also looks intentional and it works so I left it alone. This port is done as well.