Created attachment 146810 [details] shar of databases/linux-oracle-instantclient-sdk with original files. Converted databases/linux-oracle-instantclient-sdk to support staging. Note that the ports maintainers may want to modify the message about where to download the SDK source as the Oracle site which used to have the source code has changed. This change also affects linux-oracle-instantclient-basic and linux-oracle-instantclient-sqlplus ports. I recommend that instead of specifying the site, instruct the users to do an internet search for a site with the required file(s) and download the files from that site. Note that the distinfo.i386 is now distinfo.linxu32. This same change may need to be made to the other linux-oracle-instantclient ports.
Thanks! Do you have any verification available? In order of preference, examples of what I'm looking for are: 1) "poudriere testport" or "poudriere bulk -t" logs 2) "make check-plist" followed by "make stage-qa" output (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html) Also, please run "portlint" and paste the output.
Created attachment 146951 [details] shar of port files and also tests.out
Grrr... when you do an attachment the problem report seems to be immediately submitted. I ran the tests: + portlint WARN: Makefile: possible direct use of "files" "IGNORE+= due to Oracle license restrictions, you must fetch the source distribution manually. Please do a network search for ${DISTFILES} and find the current Oracle Downloads Web site. After registration and accepting the Oracle License, download the distribution files and place them in ${DISTDIR}/${DIST_SUBDIR}/" found. if so, use ${FILESDIR} instead. WARN: Makefile: Consider defining LICENSE. 0 fatal errors and 2 warnings found. + make check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) + make stage-qa ====> Running Q/A tests (stage-qa)
Okay, thanks. Moving to patch-ready then.
er, never provide a shar for an existing port (use concatenated patched instead). Double never include a test log in a shar (you can have more than 1 attachment in a PR) That makes this update a whole lot harder now. Is there any chance you upload a diff with just the changes done to the port?
ping. papowell, when do you expect to update this PR?
I'm going to remove this port in as little as 12 hours from now. It's been 5 days without any response from submitter and we are not obligated to save this port because a half-done PR exists.
Created attachment 147141 [details] diff h
sorry for the delay on getting back to you on this.
Ok, it looks reasonable. I'll probably rework that IGNORE+= block though.
FYI, you generated the patch backwards.
This port is tabbed crazily. Somebody must not have been using tab = 8 spaces...
A commit references this bug: Author: marino Date: Wed Sep 10 00:00:55 UTC 2014 New revision: 367792 URL: http://svnweb.freebsd.org/changeset/ports/367792 Log: Stage databases/linux-oracle-instantclient-sdk PR: 193320 Submitted by: papowell (astart.com) Changes: head/databases/linux-oracle-instantclient-sdk/Makefile head/databases/linux-oracle-instantclient-sdk/distinfo.amd64 head/databases/linux-oracle-instantclient-sdk/pkg-plist
Hopefully I didn't mess anything up with my changes. Let me know if I did, thanks.