Bug 193415 - net/samba4: Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo"
Summary: net/samba4: Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Timur I. Bakeyev
URL:
Keywords: needs-qa, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-09-07 08:14 UTC by Yasuhiro Kimura
Modified: 2014-12-15 10:43 UTC (History)
1 user (show)

See Also:


Attachments
Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo". (837 bytes, patch)
2014-09-07 08:14 UTC, Yasuhiro Kimura
koobs: maintainer-approval? (timur)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-09-07 08:14:58 UTC
Created attachment 146985 [details]
Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo".
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 13:16:00 UTC
Comment on attachment 146985 [details]
Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo".

If possible please also include the following to promote quick 
resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * portlint -AC output (after addressing any outstanding issues)
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-09-07 14:32:58 UTC
(In reply to Kubilay Kocak from comment #1)
> Comment on attachment 146985 [details]
> Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo".
> 
> If possible please also include the following to promote quick 
> resolution:
> 
>  * Attach successful poudriere testport, or redports.org build logs

https://redports.org/buildarchive/20140907060601-18389/

>  * portlint -AC output (after addressing any outstanding issues)

yasu@eastasia[53473]% cd /usr/ports/net/samba4
yasu@eastasia[53474]% portlint -AC
WARN: /usr0/freebsd/ports/ports/net/samba4/pkg-plist: [1052]: Using @dirrmtry with absolute path will not work as you expected in most cases.  Use pkg-deinstall or @unexec rmdir ... if you want to remove a directory such as /var/${PORTNAME}
WARN: /usr0/freebsd/ports/ports/net/samba4/pkg-plist: [1053]: Using @dirrmtry with absolute path will not work as you expected in most cases.  Use pkg-deinstall or @unexec rmdir ... if you want to remove a directory such as /var/${PORTNAME}
WARN: /usr0/freebsd/ports/ports/net/samba4/pkg-plist: [1054]: Using @dirrmtry with absolute path will not work as you expected in most cases.  Use pkg-deinstall or @unexec rmdir ... if you want to remove a directory such as /var/${PORTNAME}
WARN: /usr0/freebsd/ports/ports/net/samba4/pkg-plist: [1055]: Using @dirrmtry with absolute path will not work as you expected in most cases.  Use pkg-deinstall or @unexec rmdir ... if you want to remove a directory such as /var/${PORTNAME}
WARN: Makefile: [486]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [390]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/usr/bin/install".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, PORTVERSION has to be set by "=", not by "?=".
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
0 fatal errors and 13 warnings found.
yasu@eastasia[53475]%
Comment 3 Timur I. Bakeyev freebsd_committer freebsd_triage 2014-09-08 22:04:56 UTC
Thanks a lot for the patch. Please, go ahead with the commit.
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-09-27 08:32:20 UTC
Reopen PR because patch is approved but not committed yet.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-12-15 00:54:50 UTC
A commit references this bug:

Author: timur
Date: Mon Dec 15 00:54:21 UTC 2014
New revision: 374733
URL: https://svnweb.freebsd.org/changeset/ports/374733

Log:
  Update port to newer version. Work around removed PLIST_REINPLACE, synced with
  samba41 configuration options.

  PR:		193415

Changes:
  head/net/samba4/Makefile
  head/net/samba4/distinfo
  head/net/samba4/pkg-plist
Comment 6 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-12-15 10:43:18 UTC
The chage is incorporated in r374733.