Bug 193441 - [MAINTAINER] textproc/urlview: Remove unnecessary DESTDIR MAKE_ENV override
Summary: [MAINTAINER] textproc/urlview: Remove unnecessary DESTDIR MAKE_ENV override
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2014-09-07 18:29 UTC by Zsolt Udvari
Modified: 2014-09-08 20:02 UTC (History)
1 user (show)

See Also:


Attachments
The patch (372 bytes, patch)
2014-09-07 18:29 UTC, Zsolt Udvari
uzsolt: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2014-09-07 18:29:37 UTC
Created attachment 147024 [details]
The patch

DESTDIR=${STAGEDIR} in MAKE_ENV is unneeded
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-08 02:01:02 UTC
If possible please also include the following QA results to promote quick 
resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * portlint -AC output (after addressing any outstanding issues)
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2014-09-08 04:57:44 UTC
Redports amd64:
https://redports.org/~uzsolt/20140907182052-02791-241708/urlview-0.9_7.log
Redports i386 (make[1]: "/usr/share/mk/bsd.port.mk" line 16: Cannot open /usr/ports/Mk/bsd.port.mk):
https://redports.org/~uzsolt/20140907182052-02791-241709/.txz.log

portlint -AC:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.
Comment 3 Tilman Keskinoz freebsd_committer freebsd_triage 2014-09-08 20:02:38 UTC
committed, thanks
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-09-08 20:02:40 UTC
A commit references this bug:

Author: arved
Date: Mon Sep  8 20:02:12 UTC 2014
New revision: 367690
URL: http://svnweb.freebsd.org/changeset/ports/367690

Log:
  Remove unnecessary DESTDIR MAKE_ENV override

  PR:		193441
  Submitted by:	maintainer

Changes:
  head/textproc/urlview/Makefile