Bug 193522 - [PATCH] mail/sympa: update to 6.1.23
Summary: [PATCH] mail/sympa: update to 6.1.23
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Chris Rees
URL:
Keywords:
: 194298 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-10 13:42 UTC by geoffroy desvernay
Modified: 2015-03-10 20:33 UTC (History)
3 users (show)

See Also:
dgeo: maintainer-feedback+


Attachments
sympa-6.1.22.patch (1.62 KB, patch)
2014-09-10 13:42 UTC, geoffroy desvernay
no flags Details | Diff
Patch updated for 6.1.23 (1.71 KB, patch)
2014-10-11 15:06 UTC, geoffroy desvernay
no flags Details | Diff
Same patch with a @sample data_structure.version (9.36 KB, patch)
2014-10-25 20:43 UTC, geoffroy desvernay
no flags Details | Diff
update + corrections + maintainer (9.47 KB, patch)
2014-12-17 23:11 UTC, geoffroy desvernay
dgeo: maintainer-approval? (crees)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description geoffroy desvernay 2014-09-10 13:42:03 UTC
Created attachment 147171 [details]
sympa-6.1.22.patch

- Update to 6.1.22
- Add Net::DNS as stated in changelog for 6.1.21
  http://www.sympa.org/distribution/latest-stable/NEWS

I'm not sure how to handle %%ETCDIR%%/data_structure.version, as it should not be overwritten 
by pkg upgrade (to let sympa make his database migration)

Port maintainer (crees@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: update, diff: SVN)
Comment 1 Chris Rees freebsd_committer freebsd_triage 2014-09-10 18:24:34 UTC
Hi Geoffroy,

You are correct indeed the data_structure.version file should be kept...  I'll look into an rc script solution.

Chris
Comment 2 geoffroy desvernay 2014-10-11 15:03:58 UTC
*** Bug 194298 has been marked as a duplicate of this bug. ***
Comment 3 geoffroy desvernay 2014-10-11 15:06:12 UTC
Created attachment 148192 [details]
Patch updated for 6.1.23
Comment 4 geoffroy desvernay 2014-10-25 20:43:14 UTC
Created attachment 148646 [details]
Same patch with a @sample data_structure.version

Maybe a mistake, but @sample seems to handle this perfectly… at least works for me® :)

Also changed in plist:
 - @dirrm(try) to @dir to make portlint happy.
 - removed @owner for libexec/sympa/*: sympa doesn't need write privileges here (do it ?)
 - changed broken ${CHOWN} from Makefile to "@owner" in plist for %%DATADIR%%/{list_data,bounce,arc} (owned by sympa:sympa for real)
 - removed .keep files from these folders (wasn't this a workaround for old port-system bug?)

HTH,
Comment 5 geoffroy desvernay 2014-12-17 23:11:08 UTC
Created attachment 150700 [details]
update + corrections + maintainer

Add MAINTAINER=myself as discussed with current maintainer offline
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-12-19 17:17:59 UTC
A commit references this bug:

Author: crees
Date: Fri Dec 19 17:17:24 UTC 2014
New revision: 374954
URL: https://svnweb.freebsd.org/changeset/ports/374954

Log:
  - Update to 6.1.22
  - Add Net::DNS as stated in changelog for 6.1.21

  Also changed in plist:
   - @dirrm(try) to @dir to make portlint happy.
   - removed @owner for libexec/sympa/*: sympa doesn't need write privileges here (do it ?)
   - changed broken ${CHOWN} from Makefile to "@owner" in plist for %%DATADIR%%/{list_data,bounce,arc} (owned by sympa:sympa for real)

  Pass maintainership to submitter (thanks a lot!)

  PR:		ports/193522
  Submitted by:	Geoffroy Desvernay

Changes:
  head/mail/sympa/Makefile
  head/mail/sympa/distinfo
  head/mail/sympa/pkg-plist
Comment 7 Chris Rees freebsd_committer freebsd_triage 2014-12-19 17:20:36 UTC
Committed.  Thanks!
Comment 8 mickael.maillot 2015-01-06 17:07:28 UTC
Sorry but at least libexec/sympa/wwsympa-wrapper.fcgi need to be own by sympa user.
otherwise, the fastcgi process will not change user to sympa and the following error occur:
err [robot ] [client XX.XX.XX.XX] Config error: wwsympa should run with UID 200 (instead of 0). *** Switching to maintenance mode. ***

After the chown sympa, the fastcgi process switched correctly to sympa and everything works like before.
Comment 9 geoffroy desvernay 2015-02-25 22:57:54 UTC
Sorry for the delay...
You're right, didn't test it under apache…

I'll correct this ASAP (hope next week)
Comment 10 geoffroy desvernay 2015-03-10 20:33:51 UTC
owner problem fixed in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198508 with 6.1.24 update.